Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane #2601

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 13, 2024

I backport this for parity with 11.0.24-oracle.

I resolved Copyright and import (actually unneeded) in JTabbedPane.java.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8322239 needs maintainer approval

Issue

  • JDK-8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2601/head:pull/2601
$ git checkout pull/2601

Update a local copy of the PR:
$ git checkout pull/2601
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2601/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2601

View PR using the GUI difftool:
$ git pr show -t 2601

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2601.diff

Webrev

Link to Webrev Comment

@GoeLin GoeLin marked this pull request as ready for review March 13, 2024 12:02
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3b1062d45df69d4cf8479c6a65602bd2453ab885 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane Mar 13, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 13, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 13, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 0f09d0b: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg
  • 1d102e8: 8248667: Need support for building native libraries located in the test/lib directory
  • 7de6f3f: 8314283: Support for NSS tests on aarch64 platforms
  • a097faa: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
  • 1b3c570: 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all
  • 5cf250f: 8292716: Configure should check that jtreg is of the required version
  • 069fbd7: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
  • 21b88db: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14
  • 84ff9b3: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java
  • 29f300e: 8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 14, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Mar 14, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 14, 2024

Going to push as commit d1bdb25.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 2921ad6: 8321489: Update LCMS to 2.16
  • 0f09d0b: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg
  • 1d102e8: 8248667: Need support for building native libraries located in the test/lib directory
  • 7de6f3f: 8314283: Support for NSS tests on aarch64 platforms
  • a097faa: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
  • 1b3c570: 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all
  • 5cf250f: 8292716: Configure should check that jtreg is of the required version
  • 069fbd7: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
  • 21b88db: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14
  • 84ff9b3: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java
  • ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/c8ca55bafa8137f48ccb184539e8fa4e609faa09...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 14, 2024
@openjdk openjdk bot closed this Mar 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2024
@openjdk
Copy link

openjdk bot commented Mar 14, 2024

@GoeLin Pushed as commit d1bdb25.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8264152 branch March 14, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant