8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space

[TheRealMDoerr]

Backport of JDK-8326101. Version from 22u applies cleanly, but 11u uses NULL instead of nullptr (replaced by 2nd commit).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8326101 needs maintainer approval

Issue

• JDK-8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space (Bug - P3 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2604/head:pull/2604
$ git checkout pull/2604

Update a local copy of the PR:
$ git checkout pull/2604
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2604/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2604

View PR using the GUI difftool:
$ git pr show -t 2604

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2604.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• cb1b9a6: 8292717: Clean up checking of testing requirements in configure

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (c556d35b)

[openjdk]

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[MBaesken]

Version from 22u applies cleanly, but 11u uses NULL instead of nullptr

Searching through the 11u-dev sources, I find a lot of nullptr usages. So why not allow it in 11u(_dev) hotspot too ? Would make life easier for backporters.

[TheRealMDoerr]

/approval request JDK 11 is affected by this bug. The fix is small, only touches two PPC64 files and the version from 22u applies cleanly, but 11u requires a trivial adaptation which has been reviewed. The fix has been tested in head for some time and retested in 22u, 21u-dev, 17u-dev and 11u-dev. No regression found.

[TheRealMDoerr]

GHA test failure is obviously unrelated.

[TheRealMDoerr]

Version from 22u applies cleanly, but 11u uses NULL instead of nullptr

Searching through the 11u-dev sources, I find a lot of nullptr usages. So why not allow it in 11u(_dev) hotspot too ? Would make life easier for backporters.

The JDK allows usage of nullptr, but hotspot doesn't: "error: 'nullptr' was not declared in this scope"

[openjdk]

@TheRealMDoerr
8326101: The approval request has been created successfully.

[TheRealMDoerr]

/integrate

[openjdk]

Going to push as commit c5ba4b5.
Since your change was applied there have been 2 commits pushed to the master branch:

• 7482298: 8325326: [PPC64] Don't relocate in case of allocation failure
• cb1b9a6: 8292717: Clean up checking of testing requirements in configure

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit c5ba4b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.