-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8015739: Background of JInternalFrame is located out of JInternalFrame #2607
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
/integrate |
Going to push as commit ac9d090.
Your commit was automatically rebased without conflicts. |
I backport this because it fixes an obvious problem.
The backport is based on the commit to 17.
The test reproduces the issue and passes with the fix.
I had to resolve due to context.
I adapted the test to work with Java 11.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2607/head:pull/2607
$ git checkout pull/2607
Update a local copy of the PR:
$ git checkout pull/2607
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2607/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2607
View PR using the GUI difftool:
$ git pr show -t 2607
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2607.diff
Webrev
Link to Webrev Comment