Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8015739: Background of JInternalFrame is located out of JInternalFrame #2607

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 18, 2024

I backport this because it fixes an obvious problem.
The backport is based on the commit to 17.
The test reproduces the issue and passes with the fix.

I had to resolve due to context.
I adapted the test to work with Java 11.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8015739 needs maintainer approval

Issue

  • JDK-8015739: Background of JInternalFrame is located out of JInternalFrame (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2607/head:pull/2607
$ git checkout pull/2607

Update a local copy of the PR:
$ git checkout pull/2607
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2607/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2607

View PR using the GUI difftool:
$ git pr show -t 2607

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2607.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8015739: Background of JInternalFrame is located out of JInternalFrame

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • cb1b9a6: 8292717: Clean up checking of testing requirements in configure

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@GoeLin GoeLin changed the title Backport ... Backport 7fb1fb0fa6bfb8258ac0191611f445b83a23408e Mar 19, 2024
@GoeLin GoeLin marked this pull request as ready for review March 19, 2024 14:12
@openjdk openjdk bot changed the title Backport 7fb1fb0fa6bfb8258ac0191611f445b83a23408e 8015739: Background of JInternalFrame is located out of JInternalFrame Mar 19, 2024
@openjdk
Copy link

openjdk bot commented Mar 19, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 19, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 19, 2024

Webrevs

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Mar 19, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 19, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Mar 20, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 20, 2024

Going to push as commit ac9d090.
Since your change was applied there have been 3 commits pushed to the master branch:

  • c5ba4b5: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • 7482298: 8325326: [PPC64] Don't relocate in case of allocation failure
  • cb1b9a6: 8292717: Clean up checking of testing requirements in configure

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 20, 2024
@openjdk openjdk bot closed this Mar 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 20, 2024
@openjdk
Copy link

openjdk bot commented Mar 20, 2024

@GoeLin Pushed as commit ac9d090.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8015739 branch March 20, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants