-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8261302: NMT: Improve malloc site table hashing #2608
Conversation
Reviewed-by: zgu, lucy
👋 Welcome back Delawen! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. Please note that this also needs JDK-8261520 as a follow-up.
/approval JDK-8261302 request Fix Request |
Hi @Delawen, I don't see why this should be backported to a stable release as 11. |
Hi @GoeLin , this is part of a (smallish) chain of changes that would make NMT in 11 feature-equivalent to 21. Since NMT continues to be very important to us, and since the changes in general are low-risk, I suggested making these backports. |
I have a list of potential NMT improvements (following @tstuefe steps) that could be backported here. To me it makes sense to be as similar as JDK21, but of course this is not my call, so let me know if I should proceed. |
Hi @Delawen, could you please edit the comment and add links to the bugIDs? |
Starting with 21 then! Comment edited. |
Hi @Delawen, after checking with the fellow maintainers we decided this is too much for 11. |
No problem, I will focus on newer versions of OpenJDK :) |
This is the same fix that was applied in openjdk/jdk@a3d6e371 for https://bugs.openjdk.org/browse/JDK-8261302
It simplifies the way of calculating the hash of a stack.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2608/head:pull/2608
$ git checkout pull/2608
Update a local copy of the PR:
$ git checkout pull/2608
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2608/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2608
View PR using the GUI difftool:
$ git pr show -t 2608
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2608.diff
Webrev
Link to Webrev Comment