8159927: Add a test to verify JMOD files created in the images do not have debug symbols

[SoniaZaldana]

Hi all,

This PR contains a backport of 6c0bebccb0092d9726eb89a054e023e92edf7ca6.

Patch is not clean. Test won't build in 11 because it can't find import jdk.internal.util.OperatingSystem.

This class was introduced in 21 as part of JDK-8303485.

I've worked around that by removing the dependency to that utility function and checking the operating system with System.getProperty("os.name").

Testing:

• Added test passes.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8159927 needs maintainer approval

Issue

• JDK-8159927: Add a test to verify JMOD files created in the images do not have debug symbols (Enhancement - P4 - Approved)

Reviewers

• Lutz Schmidt (@RealLucy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2609/head:pull/2609
$ git checkout pull/2609

Update a local copy of the PR:
$ git checkout pull/2609
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2609/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2609

View PR using the GUI difftool:
$ git pr show -t 2609

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2609.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@SoniaZaldana This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8159927: Add a test to verify JMOD files created in the images do not have debug symbols

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 74 new commits pushed to the master branch:

• 533b458: 8293965: Code signing warnings after JDK-8293550
• e73d88f: 8315609: Open source few more swing text/html tests
• ff1b975: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
• f1687ea: 8306634: Open source AWT Event related tests
• 4ca2d02: 8305874: Open source AWT Key, Text Event related tests
• 7491ed4: 8302069: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java update
• 295a8cd: 8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC
• 3f12da5: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests
• e1662fb: 8316154: Opensource JTextArea manual tests
• 0be4705: 8315824: Open source several Swing Text/HTML related tests
• ... and 64 more: https://git.openjdk.org/jdk11u-dev/compare/7ed3c3ef2c70f83fdb35561fc2d6cb5d4814a606...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealLucy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (64163801)

[bridgekeeper]

@SoniaZaldana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[amosshi]

SAP nightlies passed on 2024-04-16,17,19,20

• Automated jtreg test: jtreg_jdk_tier1
• jdk/modules/etc/JmodExcludedFiles.java: SUCCESSFUL GitHub 📊⏲ - [703 msec]

[RealLucy]

LGTM.

[openjdk]

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[SoniaZaldana]

/integrate

[openjdk]

@SoniaZaldana
Your change (at version 6416380) is now ready to be sponsored by a Committer.

[GoeLin]

/sponsor

[openjdk]

Going to push as commit 7c04756.
Since your change was applied there have been 79 commits pushed to the master branch:

• f3d0f2b: 8306031: Update IANA Language Subtag Registry to Version 2023-04-13
• dabf4d1: 8220202: Simplify/standardize method naming for HtmlTree
• decacb8: 8282017: sun/net/www/protocol/https/HttpsURLConnection/B6216082.java fails with "SocketException: Unexpected end of file from server"
• 1ea1852: 8187759: Background not refreshed when painting over a transparent JFrame
• 6cce290: 8318854: [macos14] Running any AWT app prints Secure coding warning
• 533b458: 8293965: Code signing warnings after JDK-8293550
• e73d88f: 8315609: Open source few more swing text/html tests
• ff1b975: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
• f1687ea: 8306634: Open source AWT Event related tests
• 4ca2d02: 8305874: Open source AWT Key, Text Event related tests
• ... and 69 more: https://git.openjdk.org/jdk11u-dev/compare/7ed3c3ef2c70f83fdb35561fc2d6cb5d4814a606...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin @SoniaZaldana Pushed as commit 7c04756.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.