New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8248671: AArch64: Remove unused variables #261
Conversation
|
This backport pull request has now been updated with issue and summary from the original commit. |
@rnkovacs This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change.
|
/issue add JDK-8254641 |
@rnkovacs |
/contributor add Bernhard Urban-Forster burban@openjdk.org |
@rnkovacs |
/issue remove JDK-8254641 |
@rnkovacs |
/integrate |
/sponsor |
Going to push as commit c81c8e8.
Your commit was automatically rebased without conflicts. |
@RealCLanger @rnkovacs Pushed as commit c81c8e8. |
@rnkovacs You need to request push approval for jdk11u backports, even when a PR is marked as "ready". So you should have waited with /integrate until the JBS issue (https://bugs.openjdk.java.net/browse/JDK-8248671) has label jdk11u-fix-xes. I have approved and sponsored this now. |
@RealCLanger Sorry about that - I was so focused on getting the GH workflow right, I forgot that's still needed. I've requested authorship so that I can do the JBS administration myself (it's inconvenient to ask someone all the time). The two commits you've pushed for me should be enough - thank you! |
Yeah, no problem. I just wanted to make you aware of that. Ideally, maintainer approvals should also be handled via GitHub - I'll continue to propose that to Skara folks. With authorship in JBS it will at least be less cumbersome. |
Tiny change, applies cleanly.
This is part of the Windows/AArch64 port.
Progress
Issue
Contributors
<burban@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/261/head:pull/261
$ git checkout pull/261
Update a local copy of the PR:
$ git checkout pull/261
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/261/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 261
View PR using the GUI difftool:
$ git pr show -t 261
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/261.diff