Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection #2610

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Mar 19, 2024

I backport this for parity with 11.0.24-oracle.
Clean except the method is not static here.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8312383 needs maintainer approval

Issue

  • JDK-8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2610/head:pull/2610
$ git checkout pull/2610

Update a local copy of the PR:
$ git checkout pull/2610
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2610/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2610

View PR using the GUI difftool:
$ git pr show -t 2610

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2610.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 19, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 19, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 12a2863: 8315663: Open source misc awt tests
  • 50d0503: 8314495: Update to use jtreg 7.3.1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport bdd1aebea379b63ae405827074530ef8e8a7c239 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection Mar 19, 2024
@openjdk
Copy link

openjdk bot commented Mar 19, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 19, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 19, 2024

Webrevs

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 25, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

Going to push as commit c782d4c.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 12a2863: 8315663: Open source misc awt tests
  • 50d0503: 8314495: Update to use jtreg 7.3.1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 25, 2024
@openjdk openjdk bot closed this Mar 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@luchenlin Pushed as commit c782d4c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants