Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
shipilev
left a comment
There was a problem hiding this comment.
I don't think we should be adding lib-test here. It is a part of much larger JDK-8211977. Otherwise looks good.
|
|
|
Hi @shipilev, I removed the file as asked. |
|
GHA failure: StringRepeat.java: Could not reserve enough space for 2097152KB object heap. Unrelated. |
|
/integrate |
|
Going to push as commit 50d0503.
Your commit was automatically rebased without conflicts. |
I backport this as announced in https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-March/030818.html
Clean backport from 17 except for test/lib-test/TEST.ROOT.
That file is not in 11. I added it for this change. I think it makes sense to have this in 11 as well.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2612/head:pull/2612$ git checkout pull/2612Update a local copy of the PR:
$ git checkout pull/2612$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2612/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2612View PR using the GUI difftool:
$ git pr show -t 2612Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2612.diff
Webrev
Link to Webrev Comment