Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316164: Opensource JMenuBar manual test #2615

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 20, 2024

I backport this for parity with 21.0.4-oracle.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8316164 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8316164: Opensource JMenuBar manual test (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2615/head:pull/2615
$ git checkout pull/2615

Update a local copy of the PR:
$ git checkout pull/2615
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2615/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2615

View PR using the GUI difftool:
$ git pr show -t 2615

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2615.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 20, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 20, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 8f4dfc443ba5820f5799fff1418d6632d502d57b 8316164: Opensource JMenuBar manual test Mar 20, 2024
@openjdk
Copy link

openjdk bot commented Mar 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 20, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 20, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Mar 20, 2024

I meant to backport this to 21 ...

@GoeLin GoeLin closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
1 participant