-
Notifications
You must be signed in to change notification settings - Fork 252
8310380: Handle problems in core-related tests on macOS when codesign tool does not work #2620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into |
|
@luchenlin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
RealLucy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
|
|
/integrate |
|
Going to push as commit b05024a.
Your commit was automatically rebased without conflicts. |
|
@luchenlin Pushed as commit b05024a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I backport this for parity with 11.0.24-oracle.
test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
Backport to the origin file.
Other's clean.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2620/head:pull/2620$ git checkout pull/2620Update a local copy of the PR:
$ git checkout pull/2620$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2620/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2620View PR using the GUI difftool:
$ git pr show -t 2620Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2620.diff
Webrev
Link to Webrev Comment