Skip to content

Conversation

@luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Mar 25, 2024

I backport this for parity with 11.0.24-oracle.

test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
Backport to the origin file.
Other's clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8310380 needs maintainer approval

Issue

  • JDK-8310380: Handle problems in core-related tests on macOS when codesign tool does not work (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2620/head:pull/2620
$ git checkout pull/2620

Update a local copy of the PR:
$ git checkout pull/2620
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2620/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2620

View PR using the GUI difftool:
$ git pr show -t 2620

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2620.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8310380: Handle problems in core-related tests on macOS when codesign tool does not work

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 5d4de36: 8286705: GCC 12 reports use-after-free potential bugs
  • 741b340: 8243010: Test support: Customizable Hex Printer
  • 518e797: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
  • 29a08f7: 8210988: Improved handling of compiler warnings in the build
  • 4117953: 8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned
  • d98b460: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • b7f78a3: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader
  • 37cfd48: 8328705: GHA: Cross-compilation jobs do not require build JDK
  • 6aa7216: 8324632: Update Zlib Data Compression Library to Version 1.3.1
  • f8225a4: 8313206: PKCS11 tests silently skip execution

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 39c104df44f17c1d65e35becd4272f73e2c6610c 8310380: Handle problems in core-related tests on macOS when codesign tool does not work Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Mar 25, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2024

Webrevs

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Mar 28, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 29, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 1, 2024

Going to push as commit b05024a.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 0073602: 8297798: Timeout with DTLSOverDatagram test template
  • 979daf5: 8264152: javax/net/ssl/DTLS/RespondToRetransmit.java timed out
  • 5d4de36: 8286705: GCC 12 reports use-after-free potential bugs
  • 741b340: 8243010: Test support: Customizable Hex Printer
  • 518e797: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
  • 29a08f7: 8210988: Improved handling of compiler warnings in the build
  • 4117953: 8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned
  • d98b460: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • b7f78a3: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader
  • 37cfd48: 8328705: GHA: Cross-compilation jobs do not require build JDK
  • ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/8c18317ef89886ffd7b917c89ab02e047b940c20...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 1, 2024
@openjdk openjdk bot closed this Apr 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2024
@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@luchenlin Pushed as commit b05024a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants