Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320005: Allow loading of shared objects with .a extension on AIX #2622

Conversation

suchismith1993
Copy link

@suchismith1993 suchismith1993 commented Mar 25, 2024

Hi all,

This pull request contains a backport of commit e85355ad from the openjdk/jdk repository.

The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320005 needs maintainer approval

Issue

  • JDK-8320005: Allow loading of shared objects with .a extension on AIX (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2622/head:pull/2622
$ git checkout pull/2622

Update a local copy of the PR:
$ git checkout pull/2622
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2622/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2622

View PR using the GUI difftool:
$ git pr show -t 2622

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2622.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2024

👋 Welcome back sroy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@suchismith1993 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8320005: Allow loading of shared objects with .a extension on AIX

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport e85355ada4ac1061c49ee9f1247d37a437c7b5ab 8320005: Allow loading of shared objects with .a extension on AIX Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

⚠️ @suchismith1993 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 25, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2024

Webrevs

@suchismith1993
Copy link
Author

/approval request This back port is required to handle dynamic libraries of AIX.

@openjdk
Copy link

openjdk bot commented Mar 26, 2024

@suchismith1993
8320005: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 26, 2024
@GoeLin
Copy link
Member

GoeLin commented Mar 27, 2024

Hi @suchismith1993, I removed your label, please first backport to 17.

@openjdk openjdk bot removed the approval label Mar 27, 2024
@suchismith1993
Copy link
Author

@GoeLin the backport for jdk17-udev is already there for review. For multiple line changes i think it went in for a review.
openjdk/jdk17u-dev#2332

@suchismith1993
Copy link
Author

/approval request This back port is required to handle dynamic libraries of AIX.

@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@suchismith1993
8320005: The approval request was already up to date.

@openjdk openjdk bot added the approval label Apr 1, 2024
@suchismith1993
Copy link
Author

@GoeLin The backport for jdk17 is complete.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 1, 2024
@suchismith1993
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@suchismith1993
Your change (at version 888c71c) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 3, 2024

Going to push as commit 6808c5c.
Since your change was applied there have been 18 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 3, 2024
@openjdk openjdk bot closed this Apr 3, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Apr 3, 2024
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 3, 2024
@openjdk
Copy link

openjdk bot commented Apr 3, 2024

@TheRealMDoerr @suchismith1993 Pushed as commit 6808c5c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants