-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8320005: Allow loading of shared objects with .a extension on AIX #2622
8320005: Allow loading of shared objects with .a extension on AIX #2622
Conversation
👋 Welcome back sroy! A progress list of the required criteria for merging this PR into |
@suchismith1993 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request This back port is required to handle dynamic libraries of AIX. |
@suchismith1993 |
Hi @suchismith1993, I removed your label, please first backport to 17. |
@GoeLin the backport for jdk17-udev is already there for review. For multiple line changes i think it went in for a review. |
/approval request This back port is required to handle dynamic libraries of AIX. |
@suchismith1993 |
@GoeLin The backport for jdk17 is complete. |
/integrate |
@suchismith1993 |
/sponsor |
Going to push as commit 6808c5c.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr @suchismith1993 Pushed as commit 6808c5c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit e85355ad from the openjdk/jdk repository.
The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2622/head:pull/2622
$ git checkout pull/2622
Update a local copy of the PR:
$ git checkout pull/2622
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2622/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2622
View PR using the GUI difftool:
$ git pr show -t 2622
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2622.diff
Webrev
Link to Webrev Comment