Skip to content

Conversation

@benty-amzn
Copy link
Contributor

@benty-amzn benty-amzn commented Mar 25, 2024

Clean backport of JDK-8273831 to fix a regression that can leave an orphaned thread. Verified with included test.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8273831 needs maintainer approval

Issue

  • JDK-8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2623/head:pull/2623
$ git checkout pull/2623

Update a local copy of the PR:
$ git checkout pull/2623
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2623/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2623

View PR using the GUI difftool:
$ git pr show -t 2623

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2623.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2024

👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@benty-amzn This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • d98b460: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • b7f78a3: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 687567822a5380fb7d8c5b54ae548b2a5c848187 8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

⚠️ @benty-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 25, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2024

Webrevs

@benty-amzn
Copy link
Contributor Author

benty-amzn commented Mar 26, 2024

/approval JDK-8273831 request Clean backport that fixes a regression which can cause orphaned threads

@openjdk
Copy link

openjdk bot commented Mar 26, 2024

@benty-amzn usage: /approval [<id>] (request|cancel) [<text>]

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 26, 2024
@benty-amzn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

Going to push as commit 4117953.
Since your change was applied there have been 2 commits pushed to the master branch:

  • d98b460: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • b7f78a3: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 27, 2024
@openjdk openjdk bot closed this Mar 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 27, 2024
@openjdk
Copy link

openjdk bot commented Mar 27, 2024

@benty-amzn Pushed as commit 4117953.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant