-
Notifications
You must be signed in to change notification settings - Fork 253
8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned #2623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into |
|
@benty-amzn This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval JDK-8273831 request Clean backport that fixes a regression which can cause orphaned threads |
|
@benty-amzn usage: |
|
/integrate |
|
Going to push as commit 4117953.
Your commit was automatically rebased without conflicts. |
|
@benty-amzn Pushed as commit 4117953. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport of JDK-8273831 to fix a regression that can leave an orphaned thread. Verified with included test.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2623/head:pull/2623$ git checkout pull/2623Update a local copy of the PR:
$ git checkout pull/2623$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2623/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2623View PR using the GUI difftool:
$ git pr show -t 2623Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2623.diff
Webrev
Link to Webrev Comment