Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310923: Refactor Currency tests to use JUnit #2625

Closed
wants to merge 4 commits into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Mar 26, 2024

I backport this for parity with 11.0.24-oracle.
Clean except some code lines are different, so make it clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8310923 needs maintainer approval

Issue

  • JDK-8310923: Refactor Currency tests to use JUnit (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2625/head:pull/2625
$ git checkout pull/2625

Update a local copy of the PR:
$ git checkout pull/2625
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2625/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2625

View PR using the GUI difftool:
$ git pr show -t 2625

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2625.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 26, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 26, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport e848d9471f5de86e5ac157b710cd7371f12f0024 8310923: Refactor Currency tests to use JUnit Mar 26, 2024
@openjdk
Copy link

openjdk bot commented Mar 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Mar 26, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 26, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 26, 2024

Webrevs

@openjdk openjdk bot added the clean label Mar 26, 2024
@openjdk
Copy link

openjdk bot commented Mar 26, 2024

@luchenlin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Mar 26, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

i556354 added 2 commits March 26, 2024 17:22
@luchenlin luchenlin closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
1 participant