-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8297798: Timeout with DTLSOverDatagram test template #2629
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout goetz_backport_8297798
git fetch https://git.openjdk.org/jdk11u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@GoeLin this pull request can not be integrated into git checkout goetz_backport_8297798
git fetch https://git.openjdk.org/jdk11u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
/integrate |
Going to push as commit 0073602. |
I backport this to streamline testing based on the change in 17.
I had to resolve DTLSOverDatagram because the code in 11 uses classes, where the code in 17 uses records.
The added code is identical in 11 and 17.
Tests pass.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2629/head:pull/2629
$ git checkout pull/2629
Update a local copy of the PR:
$ git checkout pull/2629
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2629/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2629
View PR using the GUI difftool:
$ git pr show -t 2629
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2629.diff
Webrev
Link to Webrev Comment