Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" #2631

Closed
wants to merge 2 commits into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Mar 28, 2024

Hi,

Backport of JDK-8321925.

The origin PR use int nextInt(int origin, int bound) link , but the jdk11 do not have this API. So I change int nextInt(int origin, int bound) to nextInt(bound - origin) + origin link.

Only change the testcase, the change has been verified, the risk is low.

image

Thanks,
-sendao


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8321925 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2631/head:pull/2631
$ git checkout pull/2631

Update a local copy of the PR:
$ git checkout pull/2631
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2631/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2631

View PR using the GUI difftool:
$ git pr show -t 2631

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2631.diff

Webrev

Link to Webrev Comment

Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 28, 2024

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 4714685: 8328825: Google CAInterop test failures

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport b6233c3de773fb57b23704f1fec05d8b2d9c11c0 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" Mar 28, 2024
@openjdk
Copy link

openjdk bot commented Mar 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 28, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 28, 2024

Webrevs

@openjdk openjdk bot added approval and removed approval labels Apr 7, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Hi, can anyone review this PR. thanks.

Backport of JDK-8321925. Only change the testcase, the change has been verified, the risk is low.

@sendaoYan
Copy link
Member Author

Hi, can anyone review this PR. thanks.

Backport of JDK-8321925. Only change the testcase, the change has been verified, the risk is low.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 13, 2024
@sendaoYan
Copy link
Member Author

LGTM.

Thanks for the review.

@sendaoYan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 14, 2024
@openjdk
Copy link

openjdk bot commented May 14, 2024

@sendaoYan
Your change (at version 548f51d) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented May 14, 2024

Going to push as commit 270f3cf.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 4714685: 8328825: Google CAInterop test failures

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 14, 2024
@openjdk openjdk bot closed this May 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 14, 2024
@openjdk
Copy link

openjdk bot commented May 14, 2024

@TheRealMDoerr @sendaoYan Pushed as commit 270f3cf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

/sponsor

Thanks.

@sendaoYan sendaoYan deleted the jbs8321925 branch May 14, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants