-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" #2631
Conversation
Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
@sendaoYan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi, can anyone review this PR. thanks. Backport of JDK-8321925. Only change the testcase, the change has been verified, the risk is low. |
Hi, can anyone review this PR. thanks. Backport of JDK-8321925. Only change the testcase, the change has been verified, the risk is low. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for the review. |
/integrate |
@sendaoYan |
/sponsor |
@TheRealMDoerr @sendaoYan Pushed as commit 270f3cf. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Thanks. |
Hi,
Backport of JDK-8321925.
The origin PR use
int nextInt(int origin, int bound)
link , but the jdk11 do not have this API. So I changeint nextInt(int origin, int bound)
tonextInt(bound - origin) + origin
link.Only change the testcase, the change has been verified, the risk is low.
Thanks,
-sendao
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2631/head:pull/2631
$ git checkout pull/2631
Update a local copy of the PR:
$ git checkout pull/2631
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2631/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2631
View PR using the GUI difftool:
$ git pr show -t 2631
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2631.diff
Webrev
Link to Webrev Comment