-
Notifications
You must be signed in to change notification settings - Fork 253
8310923: Refactor Currency tests to use JUnit #2632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into |
|
@luchenlin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
RealLucy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
|
|
/integrate |
|
Going to push as commit eca3696.
Your commit was automatically rebased without conflicts. |
|
@luchenlin Pushed as commit eca3696. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I backport this for parity with 11.0.24-oracle.
All Locale constructors change to new Locale("", country) due to JDK-8283698 has not been backported.
test/jdk/java/util/Currency/ValidateISO4217.java
due to the #2532
the missing part was backported to this file here
test/jdk/java/util/Currency/CurrencyTest.java
due to the private static method was not allowed here such as 'private static Stream validCurrencies()',
remove static and add '@testinstance(TestInstance.Lifecycle.PER_CLASS)'
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2632/head:pull/2632$ git checkout pull/2632Update a local copy of the PR:
$ git checkout pull/2632$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2632/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2632View PR using the GUI difftool:
$ git pr show -t 2632Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2632.diff
Webrev
Link to Webrev Comment