-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8323994: gtest runner repeats test name for every single gtest assertion #2633
Conversation
👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into |
@luchenlin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
/issue add JDK-8158048 |
/issue add JDK-8263659 |
@luchenlin |
@luchenlin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
/integrate |
Going to push as commit 2f285fd.
Your commit was automatically rebased without conflicts. |
@luchenlin Pushed as commit 2f285fd. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I backport this for parity with 11.0.24-oracle.
test/hotspot/jtreg/gtest/GTestResultParser.java
due to the file was added by JDK-8158048, so backport with JDK-8158048 and JDK-8263659 together.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2633/head:pull/2633
$ git checkout pull/2633
Update a local copy of the PR:
$ git checkout pull/2633
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2633/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2633
View PR using the GUI difftool:
$ git pr show -t 2633
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2633.diff
Webrev
Link to Webrev Comment