Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323994: gtest runner repeats test name for every single gtest assertion #2633

Closed
wants to merge 1 commit into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Mar 28, 2024

I backport this for parity with 11.0.24-oracle.

test/hotspot/jtreg/gtest/GTestResultParser.java
due to the file was added by JDK-8158048, so backport with JDK-8158048 and JDK-8263659 together.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8158048 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8263659 needs maintainer approval
  • JDK-8323994 needs maintainer approval

Issues

  • JDK-8323994: gtest runner repeats test name for every single gtest assertion (Bug - P4 - Approved)
  • JDK-8158048: Fix failure message from jtreg gtest wrapper (Bug - P3 - Approved)
  • JDK-8263659: Reflow GTestResultParser for better readability (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2633/head:pull/2633
$ git checkout pull/2633

Update a local copy of the PR:
$ git checkout pull/2633
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2633/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2633

View PR using the GUI difftool:
$ git pr show -t 2633

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2633.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 28, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8323994: gtest runner repeats test name for every single gtest assertion
8158048: Fix failure message from jtreg gtest wrapper
8263659: Reflow GTestResultParser for better readability

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 1aae980c549741cf5fc5ca51f3c299285bafa49d 8323994: gtest runner repeats test name for every single gtest assertion Mar 28, 2024
@openjdk
Copy link

openjdk bot commented Mar 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 28, 2024
@luchenlin
Copy link
Contributor Author

/issue add JDK-8158048

@luchenlin
Copy link
Contributor Author

/issue add JDK-8263659

@openjdk
Copy link

openjdk bot commented Mar 28, 2024

@luchenlin
Adding additional issue to issue list: 8158048: Fix failure message from jtreg gtest wrapper.

@openjdk
Copy link

openjdk bot commented Mar 28, 2024

@luchenlin
Adding additional issue to issue list: 8263659: Reflow GTestResultParser for better readability.

@mlbridge
Copy link

mlbridge bot commented Mar 28, 2024

Webrevs

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 3, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

Going to push as commit 2f285fd.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 9ac4063: 8299677: Formatter.format might take a long time to format an integer or floating-point
  • 6808c5c: 8320005: Allow loading of shared objects with .a extension on AIX
  • 910eb0e: 8306714: Open source few Swing event and AbstractAction tests
  • 1bbf93c: 8305943: Open source few AWT Focus related tests
  • 8e46e37: 8305942: Open source several AWT Focus related tests
  • fa8f02e: 8318727: Enable parallelism in vmTestbase/vm/gc/concurrent tests
  • e922114: 8280546: Remove hard-coded 127.0.0.1 loopback address
  • d27c9ba: 8328812: Update and move siphash license
  • b05024a: 8310380: Handle problems in core-related tests on macOS when codesign tool does not work
  • 0073602: 8297798: Timeout with DTLSOverDatagram test template
  • ... and 7 more: https://git.openjdk.org/jdk11u-dev/compare/b7f78a39c2c11e351a927da97455efa112b70d1c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 5, 2024
@openjdk openjdk bot closed this Apr 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 5, 2024
@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@luchenlin Pushed as commit 2f285fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants