Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326529: JFR: Test for CompilerCompile events fails due to time out #2641

Conversation

roberttoyonaga
Copy link
Contributor

@roberttoyonaga roberttoyonaga commented Apr 4, 2024

This is a backport of openjdk/jdk@4dd6c44

This backport limits compilation only to the test methods TestCompileCompile cares about. It should help resolve some test failures for Adoptium (see adoptium/aqa-tests#3046).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326529 needs maintainer approval

Issue

  • JDK-8326529: JFR: Test for CompilerCompile events fails due to time out (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2641/head:pull/2641
$ git checkout pull/2641

Update a local copy of the PR:
$ git checkout pull/2641
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2641/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2641

View PR using the GUI difftool:
$ git pr show -t 2641

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2641.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2024

👋 Welcome back roberttoyonaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2024

@roberttoyonaga This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8326529: JFR: Test for CompilerCompile events fails due to time out

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 4daa077: 8315834: Open source several Swing JSpinner related tests
  • 7d0de46: 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
  • dd927ed: 8305645: System Tray icons get corrupted when Windows primary monitor changes
  • 21f04a2: 8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys
  • aa16bfe: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64
  • 2e46aad: 8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used
  • eca3696: 8310923: Refactor Currency tests to use JUnit
  • 2f285fd: 8323994: gtest runner repeats test name for every single gtest assertion
  • 9ac4063: 8299677: Formatter.format might take a long time to format an integer or floating-point

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8 8326529: JFR: Test for CompilerCompile events fails due to time out Apr 4, 2024
@openjdk
Copy link

openjdk bot commented Apr 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 4, 2024

⚠️ @roberttoyonaga This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 4, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2024

Webrevs

@roberttoyonaga
Copy link
Contributor Author

/approval request for the backport of a JFR test case fix. Should be very low risk. Clean backport.

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@roberttoyonaga
8326529: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 5, 2024
@GoeLin
Copy link
Member

GoeLin commented Apr 9, 2024

Hi @roberttoyonaga, did you run the test?

@roberttoyonaga
Copy link
Contributor Author

Hi @roberttoyonaga, did you run the test?

Hi @GoeLin, yes I ran the test with jtreg -jdk:<my build of jdk11> test/jdk/jdk/jfr/event/compiler/TestCompilerCompile.java
I ran the tier1 tests too with make run-test TEST=tier1

@GoeLin
Copy link
Member

GoeLin commented Apr 9, 2024

Thanks!

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 9, 2024
@roberttoyonaga
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 9, 2024
@openjdk
Copy link

openjdk bot commented Apr 9, 2024

@roberttoyonaga
Your change (at version ab711fd) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Apr 16, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 16, 2024

Going to push as commit 8b8774d.
Since your change was applied there have been 14 commits pushed to the master branch:

  • b39a4d2: 8256660: Disable DTLS 1.0
  • 06cca19: 8324598: use mem_unit when working with sysinfo memory and swap related information
  • f9a672a: 8328540: test javax/swing/JSplitPane/4885629/bug4885629.java fails on windows hidpi
  • 8e6a71d: 8299858: [Metrics] Swap memory limit reported incorrectly when too large
  • 4941b84: 8316608: Enable parallelism in vmTestbase/gc/vector tests
  • 4daa077: 8315834: Open source several Swing JSpinner related tests
  • 7d0de46: 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
  • dd927ed: 8305645: System Tray icons get corrupted when Windows primary monitor changes
  • 21f04a2: 8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys
  • aa16bfe: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64
  • ... and 4 more: https://git.openjdk.org/jdk11u-dev/compare/6808c5c89d1e30f481ebe444f93175232bcd30e2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 16, 2024
@openjdk openjdk bot closed this Apr 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 16, 2024
@openjdk
Copy link

openjdk bot commented Apr 16, 2024

@jerboaa @roberttoyonaga Pushed as commit 8b8774d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants