Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316154: Opensource JTextArea manual tests #2660

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Apr 12, 2024

Backport of JDK-8316154

Testing

  • Local: Test passed
    • bug4265784.java: Test results: passed: 1
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies passed on 2024-04-16,17,19,20

Progress

  • JDK-8316154 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316154: Opensource JTextArea manual tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2660/head:pull/2660
$ git checkout pull/2660

Update a local copy of the PR:
$ git checkout pull/2660
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2660/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2660

View PR using the GUI difftool:
$ git pr show -t 2660

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2660.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 12, 2024

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8316154: Opensource JTextArea manual tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 33c62e4fffe33a7593fd0c01de53507bfd01dc3b 8316154: Opensource JTextArea manual tests Apr 12, 2024
@openjdk
Copy link

openjdk bot commented Apr 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 12, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 12, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 12, 2024

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Apr 21, 2024

/approval request "Backporting for parity with 11.0.24-oracle. No risk, test fix. Clean backport. SAP nightlies passed on 2024-04-16,17,19,20”

@openjdk
Copy link

openjdk bot commented Apr 21, 2024

@amosshi
8316154: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 21, 2024
@amosshi
Copy link
Contributor Author

amosshi commented Apr 23, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 23, 2024

Going to push as commit e1662fb.
Since your change was applied there have been 24 commits pushed to the master branch:

  • 0be4705: 8315824: Open source several Swing Text/HTML related tests
  • 00f8277: 8316242: Opensource SwingGraphics manual test
  • 358a35a: 8326006: Allow TEST_VM_FLAGLESS to set flagless mode
  • 7af75fb: 8304761: Update IANA Language Subtag Registry to Version 2023-03-22
  • cc23139: 8302512: Update IANA Language Subtag Registry to Version 2023-02-14
  • 215cf9b: 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output
  • a33a174: 8297449: Update JInternalFrame Metal Border code
  • 6499067: 8318599: HttpURLConnection cache issues leading to crashes in JGSS w/ native GSS introduced by 8303809
  • 583477f: 8316017: Refactor timeout handler in PassFailJFrame
  • 85d891b: 8316164: Opensource JMenuBar manual test
  • ... and 14 more: https://git.openjdk.org/jdk11u-dev/compare/4daa077a4f17729d46497bcd1dcc52bcea7ac6db...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 23, 2024
@openjdk openjdk bot closed this Apr 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 23, 2024
@openjdk
Copy link

openjdk bot commented Apr 23, 2024

@amosshi Pushed as commit e1662fb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8316154 branch April 23, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant