Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316017: Refactor timeout handler in PassFailJFrame #2666

Closed
wants to merge 1 commit into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Apr 16, 2024

I backport this for parity with 11.0.24-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316017 needs maintainer approval

Issue

  • JDK-8316017: Refactor timeout handler in PassFailJFrame (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2666/head:pull/2666
$ git checkout pull/2666

Update a local copy of the PR:
$ git checkout pull/2666
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2666/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2666

View PR using the GUI difftool:
$ git pr show -t 2666

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2666.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 16, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 16, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8316017: Refactor timeout handler in PassFailJFrame

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 3abd772672a4dfd984459283235f3b1d8fb28a49 8316017: Refactor timeout handler in PassFailJFrame Apr 16, 2024
@openjdk
Copy link

openjdk bot commented Apr 16, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 16, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 16, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 16, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 17, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 18, 2024

Going to push as commit 583477f.
Since your change was applied there have been 30 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 18, 2024
@openjdk openjdk bot closed this Apr 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 18, 2024
@openjdk
Copy link

openjdk bot commented Apr 18, 2024

@luchenlin Pushed as commit 583477f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant