-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8297449: Update JInternalFrame Metal Border code #2667
Conversation
👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into |
@luchenlin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 31 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
3758d89
to
4ef423f
Compare
@luchenlin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good.
|
/integrate |
Going to push as commit a33a174.
Your commit was automatically rebased without conflicts. |
@luchenlin Pushed as commit a33a174. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR contains a backport of
openjdk/jdk@0962957
Patch is not clean, this class src/java.desktop/share/classes/javax/swing/plaf/metal/MetalBorders.java was changed in serval commits.
I ignored these commits, and only update JInternalFrame Metal Border code
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2667/head:pull/2667
$ git checkout pull/2667
Update a local copy of the PR:
$ git checkout pull/2667
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2667/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2667
View PR using the GUI difftool:
$ git pr show -t 2667
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2667.diff
Webrev
Link to Webrev Comment