-
Notifications
You must be signed in to change notification settings - Fork 240
8306031: Update IANA Language Subtag Registry to Version 2023-04-13 #2678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into |
@luchenlin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
c3ee613
to
d943322
Compare
@luchenlin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
/integrate |
Going to push as commit f3d0f2b.
Your commit was automatically rebased without conflicts. |
@luchenlin Pushed as commit f3d0f2b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR contains a backport of
https://git.openjdk.org/jdk/commit/00b1eacad6ae2d5ea5afb1de506768e9ab960743
Patch is not clean, because this class EquivMapsGenerator.java includes the toList() method but jdk11 not have.
Other than these the rest of the code is clean.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2678/head:pull/2678
$ git checkout pull/2678
Update a local copy of the PR:
$ git checkout pull/2678
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2678/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2678
View PR using the GUI difftool:
$ git pr show -t 2678
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2678.diff
Webrev
Link to Webrev Comment