8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used #2679
Conversation
|
👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into |
|
@SoniaZaldana This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 21 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
openjdk
bot
changed the title
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout my-backport-8326591
git fetch https://git.openjdk.org/jdk11u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
Testing Machine: SAP nightlies passed on 2024-05-02
|
|
|
openjdk
bot
added
approval
ready
|
This one is ready for integration. |
|
/integrate |
|
@SoniaZaldana |
|
/sponsor |
|
Going to push as commit b8ee2aa.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
|
@TheRealMDoerr @SoniaZaldana Pushed as commit b8ee2aa. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This PR contains a backport of 43c6f0b5880899b797fab2f851bd35be1c342439.
Patch is not clean. Test won't build in 11 because it can't find
import jdk.internal.util.OperatingSystem.This class was introduced in 21 as part of JDK-8303485.
I've worked around that by removing the dependency to that utility function and checking the operating system with
test/lib/jdk/test/lib/Platform.java.Testing:
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2679/head:pull/2679$ git checkout pull/2679Update a local copy of the PR:
$ git checkout pull/2679$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2679/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2679View PR using the GUI difftool:
$ git pr show -t 2679Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2679.diff
Webrev
Link to Webrev Comment