8222669: Create and use new html.Entity class#2680
Closed
amosshi wants to merge 2 commits intoopenjdk:masterfrom
Closed
8222669: Create and use new html.Entity class#2680amosshi wants to merge 2 commits intoopenjdk:masterfrom
amosshi wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back ashi! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
Contributor
Author
|
This backport has been cancelled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of JDK-8222669. The reason is
8222669is a dependency to JDK-8253700.git applychange.rejfiles. All changes has two typesimport, or re-organize theimportsection based on the original commitContents.SPACEtoEntity.NO_BREAK_SPACEbased on the original commitSample manual merge file
NestedClassWriterImpl.java.rejTesting
MacOS 14.4.1dev-8222669-11/test/langtools/jdk/javadoc/doclet: Test results: passed:1912024-04-27Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2680/head:pull/2680$ git checkout pull/2680Update a local copy of the PR:
$ git checkout pull/2680$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2680/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2680View PR using the GUI difftool:
$ git pr show -t 2680Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2680.diff
Webrev
Link to Webrev Comment