-
Notifications
You must be signed in to change notification settings - Fork 238
8223737: HostsFileNameService doesn't handle IPv6 literal addresses correctly #2683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back ashi! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request "Clean backport. SAP nightlies passed on 2024-04-27. Tested passed in local machine MacOS 14.4.1” |
@amosshi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
This PR is for JDK-8223737, which is a real JDK code change So add this real JDK change to OpenJDK 11 for a test case is not a good idea, if the JDK-8223737 itself is not required. We will close this PR. |
Backport of JDK-8223737, dependency of JDK-8314517
Testing
MacOS 14.4.1
InternalNameServiceWithHostsFileTest.java
: Test results: passed: 12024-04-27
java/net/InetAddress/InternalNameServiceWithHostsFileTest.java
: SUCCESSFUL GitHub 📊⏲ - [2,513 msec]Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2683/head:pull/2683
$ git checkout pull/2683
Update a local copy of the PR:
$ git checkout pull/2683
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2683/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2683
View PR using the GUI difftool:
$ git pr show -t 2683
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2683.diff
Webrev
Link to Webrev Comment