8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows #2688

amosshi · 2024-04-26T21:36:32Z

Backport of JDK-8253980

This PR contains two commits
Commit 1: is a de facto clean back port of original commit
- bug7158712.java is a clean git apply
- ProblemList.txt is a manual change based on original commit, can be considered as clean
Commit 2
- A line popup.show() has been added to avoid the test case failure with message:
  - IllegalComponentStateException: component must be showing on the screen to determine its location

Testing

Local: Test passed
- bug7158712.java: Test results: passed: 1
Pipeline: All checks have passed
Testing Machine: SAP nightlies SKIPPED on 2024-04-28
- Automated jtreg test: jtreg_jdk_tier4
- javax/swing/plaf/synth/7158712/bug7158712.java: SKIPPED [Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub 📊 - [0 msec]

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8253980 needs maintainer approval

Issue

JDK-8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows (Bug - P4 - Approved)

Reviewers

Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2688/head:pull/2688
$ git checkout pull/2688

Update a local copy of the PR:
$ git checkout pull/2688
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2688/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2688

View PR using the GUI difftool:
$ git pr show -t 2688

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2688.diff

Webrev

Link to Webrev Comment

…en to determine its location

bridgekeeper · 2024-04-26T21:36:44Z

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

amosshi · 2024-04-26T21:37:45Z

test/jdk/javax/swing/plaf/synth/7158712/bug7158712.java

@@ -106,6 +106,7 @@ public Point call() throws Exception {
            @Override
            public void run() {
                BasicComboPopup popup = (BasicComboPopup) comboBox.getAccessibleContext().getAccessibleChild(0);
+                popup.show();



Adding this line to fix the following test case failure:

IllegalComponentStateException: component must be showing on the screen to determine its location

java.lang.reflect.InvocationTargetException at java.desktop/java.awt.EventQueue.invokeAndWait(EventQueue.java:1367) at java.desktop/java.awt.EventQueue.invokeAndWait(EventQueue.java:1342) at java.desktop/javax.swing.SwingUtilities.invokeAndWait(SwingUtilities.java:1480) at bug7158712.main(bug7158712.java:105) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138) at java.base/java.lang.Thread.run(Thread.java:829) Caused by: java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location at java.desktop/java.awt.Component.getLocationOnScreen_NoTreeLock(Component.java:2101) at java.desktop/java.awt.Component.getLocationOnScreen(Component.java:2075) at bug7158712$3.run(bug7158712.java:110) at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:303) at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:770) at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721) at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85) at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:740) at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203) at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124) at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113) at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109) at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90) JavaTest Message: Test threw exception: java.lang.reflect.InvocationTargetException JavaTest Message: shutting down test STATUS:Failed.`main' threw exception: java.lang.reflect.InvocationTargetException

Why is the popup.show() not needed in higher releases ? Is there maybe some other backport missing?

openjdk · 2024-04-26T21:37:50Z

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

b7822c3: 8331643: [11u]: Bump GHA bootstrap JDK to 11.0.23
3f636f3: 8310818: Refactor more Locale tests to use JUnit
1da8fd8: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer
cabaf74: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"
137a8b9: 8308021: Update IANA Language Subtag Registry to Version 2023-05-11
d42634b: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path
9363095: 8328194: Add a test to check default rendering engine
81f2413: 8318809: java/util/concurrent/ConcurrentLinkedQueue/WhiteBox.java shows intermittent failures on linux ppc64le and aarch64
f7d0522: 8315889: Open source several Swing HTMLDocument related tests
1e1688a: 8294137: Review running times of java.math tests
... and 6 more: https://git.openjdk.org/jdk11u-dev/compare/dabf4d16a190f5169a2eb56ff964f9a3365bce62...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-04-26T21:38:07Z

This backport pull request has now been updated with issue from the original commit.

mlbridge · 2024-04-26T21:47:20Z

Webrevs

00: Full (775744e0)

MBaesken · 2024-04-29T07:06:40Z

test/jdk/javax/swing/plaf/synth/7158712/bug7158712.java

@@ -106,6 +106,7 @@ public Point call() throws Exception {
            @Override
            public void run() {
                BasicComboPopup popup = (BasicComboPopup) comboBox.getAccessibleContext().getAccessibleChild(0);
+                popup.show();



Why is the popup.show() not needed in higher releases ? Is there maybe some other backport missing?

openjdk · 2024-05-02T13:49:20Z

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

amosshi · 2024-05-06T21:21:55Z

/approval request "Backporting for parity with 11.0.24-oracle. Un-Clean backport. No risk, test fix. SAP nightlies SKIPPED on 2024-04-28. Tested passed in local machine on both Windows 11 and MacOS 14.4.1”

openjdk · 2024-05-06T21:22:29Z

@amosshi
8253980: The approval request has been created successfully.

amosshi · 2024-05-08T05:59:53Z

/integrate

openjdk · 2024-05-08T06:00:17Z

Going to push as commit 6b225d5.
Since your change was applied there have been 19 commits pushed to the master branch:

b9cb572: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02
c542dc9: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
4202063: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException
b7822c3: 8331643: [11u]: Bump GHA bootstrap JDK to 11.0.23
3f636f3: 8310818: Refactor more Locale tests to use JUnit
1da8fd8: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer
cabaf74: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"
137a8b9: 8308021: Update IANA Language Subtag Registry to Version 2023-05-11
d42634b: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path
9363095: 8328194: Add a test to check default rendering engine
... and 9 more: https://git.openjdk.org/jdk11u-dev/compare/dabf4d16a190f5169a2eb56ff964f9a3365bce62...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-05-08T06:00:24Z

@amosshi Pushed as commit 6b225d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

amosshi added 2 commits April 26, 2024 14:35

Backport bdd5782

343c423

IllegalComponentStateException: component must be showing on the scre…

775744e

…en to determine its location

amosshi commented Apr 26, 2024

View reviewed changes

openjdk bot changed the title ~~Backport bdd5782a67ac4b72a7dab5ea6eee3b38a864ffbf~~ 8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows Apr 26, 2024

openjdk bot added backport rfr Pull request is ready for review labels Apr 26, 2024

MBaesken approved these changes May 2, 2024

View reviewed changes

openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 6, 2024

openjdk bot added the integrated Pull request has been integrated label May 8, 2024

openjdk bot closed this May 8, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 8, 2024

amosshi deleted the backport-8253980 branch June 11, 2024 22:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows #2688

8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows #2688

amosshi commented Apr 26, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Apr 26, 2024

amosshi Apr 26, 2024

MBaesken Apr 29, 2024

openjdk bot commented Apr 26, 2024 •

edited

Loading

openjdk bot commented Apr 26, 2024

mlbridge bot commented Apr 26, 2024

MBaesken Apr 29, 2024

openjdk bot commented May 2, 2024

amosshi commented May 6, 2024 •

edited

Loading

openjdk bot commented May 6, 2024

amosshi commented May 8, 2024

openjdk bot commented May 8, 2024

openjdk bot commented May 8, 2024

8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows #2688

8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows #2688

Conversation

amosshi commented Apr 26, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Apr 26, 2024

amosshi Apr 26, 2024

Choose a reason for hiding this comment

MBaesken Apr 29, 2024

Choose a reason for hiding this comment

openjdk bot commented Apr 26, 2024 • edited Loading

openjdk bot commented Apr 26, 2024

mlbridge bot commented Apr 26, 2024

Webrevs

MBaesken Apr 29, 2024

Choose a reason for hiding this comment

openjdk bot commented May 2, 2024

amosshi commented May 6, 2024 • edited Loading

openjdk bot commented May 6, 2024

amosshi commented May 8, 2024

openjdk bot commented May 8, 2024

openjdk bot commented May 8, 2024

amosshi commented Apr 26, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Apr 26, 2024 •

edited

Loading

amosshi commented May 6, 2024 •

edited

Loading