Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315889: Open source several Swing HTMLDocument related tests #2690

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Apr 26, 2024

Backport of JDK-8315889

Testing

  • Local: Test passed
    • bug4226914.java: Test results: passed: 1
    • bug4251593.java: Test results: passed: 1
    • bug4687405.java: Test results: passed: 1
    • bug4213373.java: Test results: passed: 1
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies passed on 2024-04-28
    • Automated jtreg test: jtreg_jdk_tier4
    • javax/swing/text/html/HTMLDocument/bug4226914.java: SUCCESSFUL GitHub πŸ“Šβ² - [11,588 msec]
    • javax/swing/text/html/HTMLDocument/bug4251593.java: SUCCESSFUL GitHub πŸ“Šβ² - [11,735 msec]
    • javax/swing/text/html/HTMLDocument/bug4687405.java: SUCCESSFUL GitHub πŸ“Šβ² - [11,841 msec]
    • javax/swing/text/html/HTMLEditorKit/bug4213373.java: SUCCESSFUL GitHub πŸ“Šβ² - [9,509 msec]

Progress

  • JDK-8315889 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315889: Open source several Swing HTMLDocument related tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2690/head:pull/2690
$ git checkout pull/2690

Update a local copy of the PR:
$ git checkout pull/2690
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2690/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2690

View PR using the GUI difftool:
$ git pr show -t 2690

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2690.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 26, 2024

πŸ‘‹ Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 26, 2024

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8315889: Open source several Swing HTMLDocument  related tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • f3d0f2b: 8306031: Update IANA Language Subtag Registry to Version 2023-04-13

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➑️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 8f46abc938ffe338e25d5fdbdcfa0aaa12edfa58 8315889: Open source several Swing HTMLDocument related tests Apr 26, 2024
@openjdk
Copy link

openjdk bot commented Apr 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 26, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 26, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 26, 2024

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Apr 28, 2024

/approval request "Backporting for parity with 11.0.24-oracle. Clean backport. No risk, test fix. SAP nightlies passed on 2024-04-28.”

@openjdk
Copy link

openjdk bot commented Apr 28, 2024

@amosshi
8315889: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 28, 2024
@amosshi
Copy link
Contributor Author

amosshi commented Apr 28, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 28, 2024

Going to push as commit f7d0522.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 1e1688a: 8294137: Review running times of java.math tests
  • d8b297f: 8306067: Open source AWT Graphics,GridBagLayout related tests
  • 9df5688: 8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal
  • f29aa4d: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653
  • ac43e68: 8255031: Update java/util/prefs/AddNodeChangeListener.java to report more failure info
  • 7c04756: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols
  • f3d0f2b: 8306031: Update IANA Language Subtag Registry to Version 2023-04-13

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 28, 2024
@openjdk openjdk bot closed this Apr 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 28, 2024
@openjdk
Copy link

openjdk bot commented Apr 28, 2024

@amosshi Pushed as commit f7d0522.

πŸ’‘ You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8315889 branch April 28, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant