Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer #2694

Closed
wants to merge 4 commits into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Apr 30, 2024

As the description in testing.html and testing.md is added in JDK-8231351, so backport for it together.
some small change is not in testing.html, so ignore it.
test/jdk/ProblemList.txt
remain the
"sun/security/tools/keytool/NssTest.java 8204203 linux-all,windows-all"
others clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8231351 needs maintainer approval
  • JDK-8295343 needs maintainer approval

Issues

  • JDK-8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer (Bug - P3 - Approved)
  • JDK-8231351: Add notes for PKCS11 tests in the test doc (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2694/head:pull/2694
$ git checkout pull/2694

Update a local copy of the PR:
$ git checkout pull/2694
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2694/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2694

View PR using the GUI difftool:
$ git pr show -t 2694

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2694.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 30, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 30, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer
8231351: Add notes for PKCS11 tests in the test doc

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • cabaf74: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 6ce0ebb858d3112f136e12d3ad595f805f6871a0 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer Apr 30, 2024
@openjdk
Copy link

openjdk bot commented Apr 30, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Apr 30, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 30, 2024
@luchenlin
Copy link
Contributor Author

/issue add JDK-8231351

@openjdk
Copy link

openjdk bot commented Apr 30, 2024

@luchenlin
Adding additional issue to issue list: 8231351: Add notes for PKCS11 tests in the test doc.

@mlbridge
Copy link

mlbridge bot commented Apr 30, 2024

Webrevs

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented May 2, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 6, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 6, 2024

Going to push as commit 1da8fd8.
Since your change was applied there has been 1 commit pushed to the master branch:

  • cabaf74: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 6, 2024
@openjdk openjdk bot closed this May 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 6, 2024
@openjdk
Copy link

openjdk bot commented May 6, 2024

@luchenlin Pushed as commit 1da8fd8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants