Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException #2698

Closed
wants to merge 4 commits into from
Closed

8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException #2698

wants to merge 4 commits into from

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented May 6, 2024 •
edited by openjdk bot
Loading

The backport of JDK-8248194 introduced the testing of core files in test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java. This can cause issues which we are seeing on MacOS arm64. With this backport, these seem to be gone.

The fix does not exactly fit into the 11u-dev codebase, so I had to make several adpatations.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8293563 needs maintainer approval

Issue

  • JDK-8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2698/head:pull/2698
$ git checkout pull/2698

Update a local copy of the PR:
$ git checkout pull/2698
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2698/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2698

View PR using the GUI difftool:
$ git pr show -t 2698

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2698.diff

Webrev

Link to Webrev Comment

@GoeLin @RealCLanger
8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hots…
5cdad3f 
…pot.oops.UnknownOopException

Reviewed-by: lucy
Backport-of: 76f1865124025ee6f788a50e1377b82fd577548f
(cherry picked from commit 5eeb41a7294f56bc258a154c043bc540cb8de5c4)
@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2024

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 6, 2024 •
edited
Loading

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 6, 2024
@mlbridge
Copy link

mlbridge bot commented May 6, 2024 •
edited
Loading

Webrevs

@MBaesken
Copy link
Member

MBaesken commented May 6, 2024

When comparing to 17u-dev
https://github.com/openjdk/jdk17u-dev/pull/1903/files
I still see the 8269982 exclusions for macosx-aarch64 in the problem list. Why is that ? E.g. TestJmapCore.java.

@RealCLanger
Copy link
Contributor Author

When comparing to 17u-dev https://github.com/openjdk/jdk17u-dev/pull/1903/files I still see the 8269982 exclusions for macosx-aarch64 in the problem list. Why is that ? E.g. TestJmapCore.java.

Good catch. Makes sense to remove this bug id in the three places where it currently appears. All of these tests have been addressed with this change.

@theRealAph
Copy link
Contributor

The last time I tried, I couldn't get core files at all without doing a ton of fiddly config, turning off SIP, etc. Did you have to do any of that? Perhaps it's no longer a problem.

@RealCLanger
Copy link
Contributor Author

RealCLanger commented May 6, 2024 •
edited
Loading

The last time I tried, I couldn't get core files at all without doing a ton of fiddly config, turning off SIP, etc. Did you have to do any of that? Perhaps it's no longer a problem.

Hm, when current jdk11u-dev hits our ci, the MacOS arm64 test is failing with exceptions like:

sun.jvm.hotspot.oops.UnknownOopException
at jdk.hotspot.agent/sun.jvm.hotspot.oops.ObjectHeap.newOop(ObjectHeap.java:266)
at jdk.hotspot.agent/sun.jvm.hotspot.runtime.JavaThread.getThreadObj(JavaThread.java:359)
at jdk.hotspot.agent/sun.jvm.hotspot.runtime.JavaThread.getCurrentParkBlocker(JavaThread.java:411)
at jdk.hotspot.agent/sun.jvm.hotspot.runtime.DeadlockDetector.print(DeadlockDetector.java:82)
at jdk.hotspot.agent/sun.jvm.hotspot.runtime.DeadlockDetector.print(DeadlockDetector.java:39)
at jdk.hotspot.agent/sun.jvm.hotspot.tools.StackTrace.run(StackTrace.java:62)
at jdk.hotspot.agent/sun.jvm.hotspot.CommandProcessor$24.doit(CommandProcessor.java:1066)
at jdk.hotspot.agent/sun.jvm.hotspot.CommandProcessor.executeCommand(CommandProcessor.java:1974)
at jdk.hotspot.agent/sun.jvm.hotspot.CommandProcessor.executeCommand(CommandProcessor.java:1944)
at jdk.hotspot.agent/sun.jvm.hotspot.CommandProcessor.run(CommandProcessor.java:1824)
at jdk.hotspot.agent/sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:99)
at jdk.hotspot.agent/sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:40)
at jdk.hotspot.agent/sun.jvm.hotspot.SALauncher.runCLHSDB(SALauncher.java:224)
at jdk.hotspot.agent/sun.jvm.hotspot.SALauncher.main(SALauncher.java:522)

And with this modification it goes away. That's all I can say... 😉

The failing tests are
hotspot / serviceability/sa/ClhsdbFindPC.java#id1
hotspot / serviceability/sa/ClhsdbFindPC.java#id3

@MBaesken
Copy link
Member

MBaesken commented May 6, 2024

When comparing to 17u-dev https://github.com/openjdk/jdk17u-dev/pull/1903/files I still see the 8269982 exclusions for macosx-aarch64 in the problem list. Why is that ? E.g. TestJmapCore.java.

Good catch. Makes sense to remove this bug id in the three places where it currently appears. All of these tests have been addressed with this change.

You removed the bug-number 8269982, but not the references macosx-aarch64, why is that ?
Please compare to https://github.com/openjdk/jdk17u-dev/pull/1903/files .

@RealCLanger
Copy link
Contributor Author

You removed the bug-number 8269982, but not the references macosx-aarch64, why is that ? Please compare to https://github.com/openjdk/jdk17u-dev/pull/1903/files .

You could be right, the other bug ids all refer to non macos-aarch64 problems. So let's try and enable the tests for macos-aarch64.

@RealCLanger RealCLanger mentioned this pull request May 6, 2024
Merged
@MBaesken
Copy link
Member

MBaesken commented May 6, 2024

So let's try and enable the tests for macos-aarch64.

Change looks okay to me otherwise.
Should we wait for some additional test outcomes after the macos-aarch64 reenabling ?

@RealCLanger RealCLanger changed the title 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException Backport 5eeb41a7294f56bc258a154c043bc540cb8de5c4 May 6, 2024
@openjdk openjdk bot changed the title Backport 5eeb41a7294f56bc258a154c043bc540cb8de5c4 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException May 6, 2024
@openjdk
Copy link

openjdk bot commented May 6, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 6, 2024
@RealCLanger
Copy link
Contributor Author

So let's try and enable the tests for macos-aarch64.

Change looks okay to me otherwise. Should we wait for some additional test outcomes after the macos-aarch64 reenabling ?

Yes, let's wait for GHA and SAP nightlies.

@RealCLanger
Copy link
Contributor Author

Testing looks good.

@openjdk
Copy link

openjdk bot commented May 7, 2024

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 7, 2024
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 7, 2024

Going to push as commit 4202063.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 7, 2024
@openjdk openjdk bot closed this May 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 7, 2024
@openjdk
Copy link

openjdk bot commented May 7, 2024

@RealCLanger Pushed as commit 4202063.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the JDK-8293563 branch May 7, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBaesken MBaesken MBaesken approved these changes

Assignees
No one assigned
Labels
backport integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RealCLanger @MBaesken @theRealAph @GoeLin