8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket

[RealCLanger]

Hi all,

This pull request contains a backport of JDK-8325579, commit 32bf1f41 from the openjdk/jdk17u-dev repository.

The commit being backported was authored by Christoph Langer on 4 May 2024 and had no reviewers.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8325579 needs maintainer approval
• Change requires CSR request JDK-8326482 to be approved

Issues

• JDK-8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket (Bug - P3 - Approved)
• JDK-8326482: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket (CSR)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2699/head:pull/2699
$ git checkout pull/2699

Update a local copy of the PR:
$ git checkout pull/2699
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2699/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2699

View PR using the GUI difftool:
$ git pr show -t 2699

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2699.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• b7822c3: 8331643: [11u]: Bump GHA bootstrap JDK to 11.0.23

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (b6ebda62)

[openjdk]

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[RealCLanger]

/integrate

[openjdk]

Going to push as commit c542dc9.
Since your change was applied there have been 2 commits pushed to the master branch:

• 4202063: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException
• b7822c3: 8331643: [11u]: Bump GHA bootstrap JDK to 11.0.23

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit c542dc9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.