-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8263136: C4530 was reported from VS 2019 at access bridge #270
Conversation
👋 Welcome back rnkovacs! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@rnkovacs This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/contributor add Monica Beckwith mbeckwit@openjdk.org |
@rnkovacs |
/integrate |
/sponsor |
Going to push as commit f334c2e.
Your commit was automatically rebased without conflicts. |
@RealCLanger @rnkovacs Pushed as commit f334c2e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Changes apply cleanly.
This is part of the Windows/AArch64 port.
Progress
Issue
Contributors
<mbeckwit@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/270/head:pull/270
$ git checkout pull/270
Update a local copy of the PR:
$ git checkout pull/270
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/270/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 270
View PR using the GUI difftool:
$ git pr show -t 270
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/270.diff