Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331790: [11u] Remove problemlist entries after backport of JDK-8228649 #2701

Closed
wants to merge 1 commit into from

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented May 7, 2024

JDK-8228649 had already been backported to 11.0.5. JDK-8211767 was marked as duplicate of the former but in the hotspot problemlist we still find exclusions referring to it. So it seems we can drop them.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331790 needs maintainer approval

Issue

  • JDK-8331790: [11u] Remove problemlist entries after backport of JDK-8228649 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2701/head:pull/2701
$ git checkout pull/2701

Update a local copy of the PR:
$ git checkout pull/2701
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2701/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2701

View PR using the GUI difftool:
$ git pr show -t 2701

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2701.diff

Webrev

Link to Webrev Comment

Remove 8211767 exclusions
@bridgekeeper
Copy link

bridgekeeper bot commented May 7, 2024

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 7, 2024

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8331790: [11u] Remove problemlist entries after backport of JDK-8228649

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 665e1cd: 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout
  • 4c81a1c: 8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar
  • 6b225d5: 8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows
  • b9cb572: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 7, 2024
@mlbridge
Copy link

mlbridge bot commented May 7, 2024

Webrevs

Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be okay; but I still see 8211767 in the ProblemList of 17u-dev too so I wonder if it is still relevant there ?

@openjdk
Copy link

openjdk bot commented May 8, 2024

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label May 8, 2024
@RealCLanger
Copy link
Contributor Author

seems to be okay; but I still see 8211767 in the ProblemList of 17u-dev too so I wonder if it is still relevant there ?

Good observation. I've addressed this here: openjdk/jdk17u-dev#2451

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 8, 2024
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 10, 2024

Going to push as commit 91fe4e6.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 665e1cd: 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout
  • 4c81a1c: 8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar
  • 6b225d5: 8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows
  • b9cb572: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 10, 2024
@openjdk openjdk bot closed this May 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 10, 2024
@openjdk
Copy link

openjdk bot commented May 10, 2024

@RealCLanger Pushed as commit 91fe4e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the ppc64excludes branch May 10, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants