-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8331790: [11u] Remove problemlist entries after backport of JDK-8228649 #2701
Conversation
Remove 8211767 exclusions
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
@RealCLanger This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to be okay; but I still see 8211767 in the ProblemList of 17u-dev too so I wonder if it is still relevant there ?
|
Good observation. I've addressed this here: openjdk/jdk17u-dev#2451 |
/integrate |
Going to push as commit 91fe4e6.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit 91fe4e6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
JDK-8228649 had already been backported to 11.0.5. JDK-8211767 was marked as duplicate of the former but in the hotspot problemlist we still find exclusions referring to it. So it seems we can drop them.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2701/head:pull/2701
$ git checkout pull/2701
Update a local copy of the PR:
$ git checkout pull/2701
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2701/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2701
View PR using the GUI difftool:
$ git pr show -t 2701
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2701.diff
Webrev
Link to Webrev Comment