Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331750: [11u] JDK-8259530 is not backported correctly to 11u #2702

Closed
wants to merge 1 commit into from

Conversation

yukikimmura
Copy link
Contributor

@yukikimmura yukikimmura commented May 7, 2024

This bug fix addresses the issue reported in #1805 (comment).
I have confirmed that the fix passes the following tests:

  • test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java
  • All langtool tests

Could someone please review the fix?

Thanks,
Kimura Yukihiro


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331750 needs maintainer approval

Issue

  • JDK-8331750: [11u] JDK-8259530 is not backported correctly to 11u (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2702/head:pull/2702
$ git checkout pull/2702

Update a local copy of the PR:
$ git checkout pull/2702
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2702/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2702

View PR using the GUI difftool:
$ git pr show -t 2702

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2702.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 7, 2024

👋 Welcome back kyukihiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 7, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 7, 2024
@mlbridge
Copy link

mlbridge bot commented May 7, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented May 30, 2024

⚠️ @yukikimmura This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@yukikimmura
Copy link
Contributor Author

/approval request I would like to fix the issue.
The bug is a careless mistake and does not require complex logic to fix, so there is no risk.
I have also thoroughly checked the fix. Testing: All langtool tests.

@openjdk
Copy link

openjdk bot commented May 31, 2024

@yukikimmura
8331750: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 31, 2024
@RealCLanger
Copy link
Contributor

@yukikimmura As this is a regression in an 11.0.20 backport, would you mind transplanting this PR to the jdk11u repository to get it into 11.0.24? I can take care that review and approval does not take so long this time. Thanks.

@yukikimmura
Copy link
Contributor Author

I apologize for the inconvenience caused by my bug. I will transplant this PR to 11u.

Thanks,
Kimura Yukihiro

@jerboaa
Copy link
Contributor

jerboaa commented Jun 3, 2024

Please close this PR and re-apply for approval on openjdk/jdk11u#92.

@openjdk openjdk bot removed the approval label Jun 3, 2024
@yukikimmura yukikimmura closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

4 participants