-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8331750: [11u] JDK-8259530 is not backported correctly to 11u #2702
Conversation
👋 Welcome back kyukihiro! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
|
/approval request I would like to fix the issue. |
@yukikimmura |
@yukikimmura As this is a regression in an 11.0.20 backport, would you mind transplanting this PR to the jdk11u repository to get it into 11.0.24? I can take care that review and approval does not take so long this time. Thanks. |
I apologize for the inconvenience caused by my bug. I will transplant this PR to 11u. Thanks, |
Please close this PR and re-apply for approval on openjdk/jdk11u#92. |
This bug fix addresses the issue reported in #1805 (comment).
I have confirmed that the fix passes the following tests:
Could someone please review the fix?
Thanks,
Kimura Yukihiro
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2702/head:pull/2702
$ git checkout pull/2702
Update a local copy of the PR:
$ git checkout pull/2702
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2702/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2702
View PR using the GUI difftool:
$ git pr show -t 2702
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2702.diff
Webrev
Link to Webrev Comment