-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError #2707
Conversation
👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into |
@luchenlin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please fix the Copyright header.
test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java
Outdated
Show resolved
Hide resolved
@TheRealMDoerr it's fixed, please check, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
/integrate |
Going to push as commit 1d6965f.
Your commit was automatically rebased without conflicts. |
@luchenlin Pushed as commit 1d6965f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR contains a backport of
openjdk/jdk@12e9430
Patch is not clean, this file test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/hs201t002.cpp has changed by other commits, I ignored these commits and only change code for this issue.
Other than that the rest of the code is clean.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2707/head:pull/2707
$ git checkout pull/2707
Update a local copy of the PR:
$ git checkout pull/2707
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2707/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2707
View PR using the GUI difftool:
$ git pr show -t 2707
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2707.diff
Webrev
Link to Webrev Comment