Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError #2707

Closed
wants to merge 3 commits into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented May 13, 2024

This PR contains a backport of
openjdk/jdk@12e9430
Patch is not clean, this file test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/hs201t002.cpp has changed by other commits, I ignored these commits and only change code for this issue.
Other than that the rest of the code is clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8267796 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2707/head:pull/2707
$ git checkout pull/2707

Update a local copy of the PR:
$ git checkout pull/2707
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2707/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2707

View PR using the GUI difftool:
$ git pr show -t 2707

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2707.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 13, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 2a804f5: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list
  • ece9b2c: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
  • 2ff4d4e: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16
  • 59224f7: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
  • 42f7042: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • 270f3cf: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
  • 4714685: 8328825: Google CAInterop test failures

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f12200cd11c2b689618cde1902db941ee23fbf80 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 13, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label May 13, 2024
@mlbridge
Copy link

mlbridge bot commented May 13, 2024

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix the Copyright header.

@luchenlin
Copy link
Contributor Author

LGTM. Please fix the Copyright header.

@TheRealMDoerr it's fixed, please check, thanks.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openjdk
Copy link

openjdk bot commented May 16, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 16, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 17, 2024

Going to push as commit 1d6965f.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 2a804f5: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list
  • ece9b2c: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
  • 2ff4d4e: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16
  • 59224f7: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
  • 42f7042: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • 270f3cf: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
  • 4714685: 8328825: Google CAInterop test failures

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 17, 2024
@openjdk openjdk bot closed this May 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 17, 2024
@openjdk
Copy link

openjdk bot commented May 17, 2024

@luchenlin Pushed as commit 1d6965f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants