Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c #2709

Closed
wants to merge 1 commit into from
Closed

8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c #2709

wants to merge 1 commit into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented May 13, 2024 •
edited by openjdk bot
Loading

Hi all,
This is backport of JDK-8293887. It's not clean backport, because the file make/lib/CoreLibraries.gmk has been moved to make/modules/java.base/lib/CoreLibraries.gmk

Thanks!

Make test list:

  • linux x64 gcc10
  • linux x64 gcc13
  • linux aarch64 gcc10
  • linux aarch64 gcc13
  • linux riscv64 gcc13

make-linux-aarch64-gcc10.log
make-linux-aarch64-gcc13.log
make-linux-x64-gcc10.log
make-linux-x64-gcc13.log
make-linux-riscv64-gcc13.log

linux riscv64 gcc13 build jdk11u-dev failure because other reasons, the k_rem_pio2.c file not longer compile fail after this PR.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8293887 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2709/head:pull/2709
$ git checkout pull/2709

Update a local copy of the PR:
$ git checkout pull/2709
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2709/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2709

View PR using the GUI difftool:
$ git pr show -t 2709

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2709.diff

Webrev

Link to Webrev Comment

@sendaoYan
Backport 02ea338177df781912dc782e32200eaf4731a0da
b32e74a 
Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 13, 2024 •
edited
Loading

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c

Reviewed-by: aph, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 3533374: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules
  • b7596f3: 8316138: Add GlobalSign 2 TLS root certificates
  • b8ee2aa: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used
  • 1d6965f: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError
  • 2a804f5: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list
  • ece9b2c: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
  • 2ff4d4e: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16
  • 59224f7: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
  • 42f7042: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • 270f3cf: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
  • ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/6d3a41fec7a53cff7aa94641597328dca5e38d08...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph, @phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 02ea338177df781912dc782e32200eaf4731a0da 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 13, 2024
@mlbridge
Copy link

mlbridge bot commented May 13, 2024

Webrevs

@sendaoYan sendaoYan mentioned this pull request May 13, 2024
Closed
theRealAph
theRealAph approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@theRealAph theRealAph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@openjdk
Copy link

openjdk bot commented May 14, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@sendaoYan
Copy link
Member Author

/approval request Backport of JDK-8293887, disable gcc compiler maybe-uninitialized warning for k_rem_pio2.c. The change has been verified. The risk is low.

@openjdk
Copy link

openjdk bot commented May 14, 2024

@sendaoYan
8293887: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 14, 2024
phohensee
phohensee approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean backport from 17u, net of file location change.

@sendaoYan
Copy link
Member Author

Thanks all for the review and approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 15, 2024
@RealCLanger
Copy link
Contributor

@sendaoYan would you mind to integrate this today to have it in 11.0.24?

@sendaoYan
Copy link
Member Author

@sendaoYan would you mind to integrate this today to have it in 11.0.24?

Sorry, I didn't notice that the jdk17u-fix-yes label has been added.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

@sendaoYan
Your change (at version b32e74a) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented May 28, 2024

Going to push as commit 8a489e5.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 3533374: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules
  • b7596f3: 8316138: Add GlobalSign 2 TLS root certificates
  • b8ee2aa: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used
  • 1d6965f: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError
  • 2a804f5: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list
  • ece9b2c: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
  • 2ff4d4e: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16
  • 59224f7: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
  • 42f7042: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • 270f3cf: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
  • ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/6d3a41fec7a53cff7aa94641597328dca5e38d08...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 28, 2024
@openjdk openjdk bot closed this May 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

@RealCLanger @sendaoYan Pushed as commit 8a489e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8293887 branch May 28, 2024 06:09
@sendaoYan
Copy link
Member Author

/sponsor

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theRealAph theRealAph theRealAph approved these changes

@phohensee phohensee phohensee approved these changes

Assignees
No one assigned
Labels
backport integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sendaoYan @RealCLanger @theRealAph @phohensee