8326521: JFR: CompilerPhase event test fails on windows 32 bit

[roberttoyonaga]

This is a backport of openjdk/jdk@96530bc

On some systems (such as windows 32 bit) Hotspot only uses the C1 compiler in by design. The CompilerPhase JFR events are only emitted from C2 code. So the test TestCompilerPhase fails on some systems because it cannot generate the necessary CompilerPhase JFR events .

This backport prevents NeverActAsServerClassMachine from being set during the test TestCompilerPhase, so that it isn't restricted to C1. It should help resolve some test failures for Adoptium (see adoptium/aqa-tests#3045).

Testing: running test/jdk/jdk/jfr/event/compiler/TestCompilerPhase.java test passes.

---

Progress

• Change must not contain extraneous whitespace
• JDK-8326521 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8326521: JFR: CompilerPhase event test fails on windows 32 bit (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2710/head:pull/2710
$ git checkout pull/2710

Update a local copy of the PR:
$ git checkout pull/2710
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2710/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2710

View PR using the GUI difftool:
$ git pr show -t 2710

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2710.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back roberttoyonaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@roberttoyonaga This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8326521: JFR: CompilerPhase event test fails on windows 32 bit

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 74 new commits pushed to the master branch:

• 42f7042: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
• 270f3cf: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
• 4714685: 8328825: Google CAInterop test failures
• 6d3a41f: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
• 4b67c4e: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException
• 91fe4e6: 8331790: [11u] Remove problemlist entries after backport of JDK-8228649
• 665e1cd: 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout
• 4c81a1c: 8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar
• 6b225d5: 8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows
• b9cb572: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02
• ... and 64 more: https://git.openjdk.org/jdk11u-dev/compare/6808c5c89d1e30f481ebe444f93175232bcd30e2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @roberttoyonaga This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (63f72bf0)

[roberttoyonaga]

/approval request for the clean backport of a JFR test fix for TestCompilerPhase. This only affects test code so should be a low risk.

[openjdk]

@roberttoyonaga
8326521: The approval request has been created successfully.

[roberttoyonaga]

/integrate

[openjdk]

@roberttoyonaga
Your change (at version 63f72bf) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit ece9b2c.
Since your change was applied there have been 76 commits pushed to the master branch:

• 2ff4d4e: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16
• 59224f7: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
• 42f7042: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
• 270f3cf: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
• 4714685: 8328825: Google CAInterop test failures
• 6d3a41f: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
• 4b67c4e: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException
• 91fe4e6: 8331790: [11u] Remove problemlist entries after backport of JDK-8228649
• 665e1cd: 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout
• 4c81a1c: 8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar
• ... and 66 more: https://git.openjdk.org/jdk11u-dev/compare/6808c5c89d1e30f481ebe444f93175232bcd30e2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @roberttoyonaga Pushed as commit ece9b2c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.