8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match" #2712

dhanalla · 2024-05-16T19:43:53Z

backport of c0dce25
8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match"

Clean backport from tip
validated the modified test case

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8236917 needs maintainer approval

Issue

JDK-8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match" (Bug - P3 - Approved)

Reviewers

Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2712/head:pull/2712
$ git checkout pull/2712

Update a local copy of the PR:
$ git checkout pull/2712
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2712/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2712

View PR using the GUI difftool:
$ git pr show -t 2712

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2712.diff

Webrev

Link to Webrev Comment

…SA for java.lang.Object does not match" Use getTestJavaOpts() instead of getVmOptions() because of mach5 configuration settings. Reviewed-by: lmesnik, cjplummer, dholmes

…uted by SA for java.lang.Object does not match

bridgekeeper · 2024-05-16T19:44:16Z

👋 Welcome back dhanalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-05-16T19:45:04Z

@dhanalla This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match"

Use getTestJavaOpts() instead of getVmOptions() because of mach5 configuration settings.

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 91 new commits pushed to the master branch:

8578e12: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
6547a16: 8227122: [TESTBUG] Create Docker sidecar test cases
25d6e19: Merge
1e3e687: 8334441: Mark tests in jdk_security_infra group as manual
e61adf6: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
59cd1a4: 8324755: Enable parallelism in vmTestbase/gc/gctests/LargeObjects tests
569c669: 8305079: Remove finalize() from compiler/c2/Test719030
724477c: 8305081: Remove finalize() from test/hotspot/jtreg/compiler/runtime/Test8168712
cc42090: 8306466: Open source more AWT Drag & Drop related tests
8489b52: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags
... and 81 more: https://git.openjdk.org/jdk11u-dev/compare/665e1cd4f976abf89a32c12a96642cbab2c5d157...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2024-05-16T20:17:51Z

This backport pull request has now been updated with issue and summary from the original commit.

mlbridge · 2024-05-16T20:21:42Z

Webrevs

dhanalla · 2024-06-13T15:52:18Z

Adding a comment to keep this PR active.

TheRealMDoerr

Sorry for the delay. I had started a review and forgot to finish it.

TheRealMDoerr · 2024-06-17T19:28:40Z

test/hotspot/jtreg/serviceability/sa/TestInstanceKlassSizeForInterface.java

@@ -38,6 +38,7 @@
 import jdk.test.lib.process.OutputAnalyzer;
 import jdk.test.lib.SA.SATestUtils;
 import jdk.test.lib.Utils;
+import java.util.Arrays;


Please add the import where the other java.util imports are (alphabetically sorted).

@TheRealMDoerr, Thanks for reviewing the PR.

TheRealMDoerr

The blocks of imports are alphabetically sorted. Would be nice if you could clean this up. Otherwise, LGTM.

openjdk · 2024-06-26T07:54:19Z

⚠️ @dhanalla This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

TheRealMDoerr

Thanks!

dhanalla · 2024-06-27T16:20:42Z

/integrate

openjdk · 2024-06-27T16:21:33Z

@dhanalla
Your change (at version 65def81) is now ready to be sponsored by a Committer.

TheRealMDoerr · 2024-06-27T16:29:27Z

/sponsor

openjdk · 2024-06-27T16:30:26Z

Going to push as commit db9e313.
Since your change was applied there have been 91 commits pushed to the master branch:

8578e12: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
6547a16: 8227122: [TESTBUG] Create Docker sidecar test cases
25d6e19: Merge
1e3e687: 8334441: Mark tests in jdk_security_infra group as manual
e61adf6: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
59cd1a4: 8324755: Enable parallelism in vmTestbase/gc/gctests/LargeObjects tests
569c669: 8305079: Remove finalize() from compiler/c2/Test719030
724477c: 8305081: Remove finalize() from test/hotspot/jtreg/compiler/runtime/Test8168712
cc42090: 8306466: Open source more AWT Drag & Drop related tests
8489b52: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags
... and 81 more: https://git.openjdk.org/jdk11u-dev/compare/665e1cd4f976abf89a32c12a96642cbab2c5d157...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-06-27T16:30:35Z

@TheRealMDoerr @dhanalla Pushed as commit db9e313.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

coleenp and others added 2 commits May 8, 2024 19:21

8236917: TestInstanceKlassSize.java fails with "The size computed by …

c5681e9

…SA for java.lang.Object does not match" Use getTestJavaOpts() instead of getVmOptions() because of mach5 configuration settings. Reviewed-by: lmesnik, cjplummer, dholmes

backport 8236917: TestInstanceKlassSize.java fails with The size comp…

132f4d9

…uted by SA for java.lang.Object does not match

dhanalla changed the title ~~backport of c0dce25756911ce49e7d8b034d5f12a25fc3c81d~~ Backport c0dce25756911ce49e7d8b034d5f12a25fc3c81d May 16, 2024

openjdk bot changed the title ~~Backport c0dce25756911ce49e7d8b034d5f12a25fc3c81d~~ 8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match" May 16, 2024

openjdk bot added backport rfr Pull request is ready for review labels May 16, 2024

TheRealMDoerr suggested changes Jun 20, 2024

View reviewed changes

Address the CR comments

ce9f75a

TheRealMDoerr approved these changes Jun 26, 2024

View reviewed changes

address CR comments

65def81

openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 26, 2024

TheRealMDoerr approved these changes Jun 27, 2024

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 27, 2024

openjdk bot added the integrated Pull request has been integrated label Jun 27, 2024

openjdk bot closed this Jun 27, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match" #2712

8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match" #2712

dhanalla commented May 16, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented May 16, 2024

openjdk bot commented May 16, 2024 •

edited

Loading

openjdk bot commented May 16, 2024

mlbridge bot commented May 16, 2024 •

edited

Loading

dhanalla commented Jun 13, 2024

TheRealMDoerr left a comment

TheRealMDoerr Jun 17, 2024

dhanalla Jun 25, 2024

TheRealMDoerr left a comment

openjdk bot commented Jun 26, 2024

TheRealMDoerr left a comment

dhanalla commented Jun 27, 2024

openjdk bot commented Jun 27, 2024

TheRealMDoerr commented Jun 27, 2024

openjdk bot commented Jun 27, 2024

openjdk bot commented Jun 27, 2024

8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match" #2712

8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match" #2712

Conversation

dhanalla commented May 16, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented May 16, 2024

openjdk bot commented May 16, 2024 • edited Loading

openjdk bot commented May 16, 2024

mlbridge bot commented May 16, 2024 • edited Loading

Webrevs

dhanalla commented Jun 13, 2024

TheRealMDoerr left a comment

Choose a reason for hiding this comment

TheRealMDoerr Jun 17, 2024

Choose a reason for hiding this comment

dhanalla Jun 25, 2024

Choose a reason for hiding this comment

TheRealMDoerr left a comment

Choose a reason for hiding this comment

openjdk bot commented Jun 26, 2024

TheRealMDoerr left a comment

Choose a reason for hiding this comment

dhanalla commented Jun 27, 2024

openjdk bot commented Jun 27, 2024

TheRealMDoerr commented Jun 27, 2024

openjdk bot commented Jun 27, 2024

openjdk bot commented Jun 27, 2024

dhanalla commented May 16, 2024 •

edited by openjdk bot

Loading

openjdk bot commented May 16, 2024 •

edited

Loading

mlbridge bot commented May 16, 2024 •

edited

Loading