Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327137: Add test for ConcurrentModificationException in BasicDirectoryModel #2713

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented May 17, 2024

I backport this for parity with 11.0.24-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8327137 needs maintainer approval

Issue

  • JDK-8327137: Add test for ConcurrentModificationException in BasicDirectoryModel (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2713/head:pull/2713
$ git checkout pull/2713

Update a local copy of the PR:
$ git checkout pull/2713
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2713/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2713

View PR using the GUI difftool:
$ git pr show -t 2713

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2713.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 17, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9731b1c8b02d957985f4fb40acd93fb67747a9f0 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel May 17, 2024
@openjdk
Copy link

openjdk bot commented May 17, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 17, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 17, 2024
@mlbridge
Copy link

mlbridge bot commented May 17, 2024

Webrevs

@TheRealMDoerr
Copy link
Contributor

TheRealMDoerr commented May 20, 2024

ConcurrentModification.java:187: error: ';' expected
Records are not supported in JDK 11.

@TheRealMDoerr
Copy link
Contributor

I think we need to postpone this one. JDK-8327137 has related issues which will also need to get ready for backport.

@luchenlin
Copy link
Contributor Author

postpone this one due to some related issues.

@luchenlin luchenlin closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants