Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331746: Create a test to verify that the cmm id is not ignored #2716

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented May 17, 2024

Hi all,

This pull request contains a backport of commit 7c750fd9 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 17 May 2024 and was reviewed by Phil Race, Dmitry Markov and Alexey Ivanov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331746 needs maintainer approval

Issue

  • JDK-8331746: Create a test to verify that the cmm id is not ignored (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2716/head:pull/2716
$ git checkout pull/2716

Update a local copy of the PR:
$ git checkout pull/2716
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2716/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2716

View PR using the GUI difftool:
$ git pr show -t 2716

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2716.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 17, 2024

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8331746: Create a test to verify that the cmm id is not ignored

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 4556aa9: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab
  • 7b377ac: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
  • 31a780d: 8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free
  • c35d30d: 8331263: Bump update version for OpenJDK: jdk-11.0.25
  • 47fd86c: 8273153: Consolidate file_exists into os:file_exists
  • 8a489e5: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c
  • 3533374: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules
  • b7596f3: 8316138: Add GlobalSign 2 TLS root certificates
  • b8ee2aa: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 7c750fd95b83d0a93b0cce681dcfbbae1f220fdd 8331746: Create a test to verify that the cmm id is not ignored May 17, 2024
@openjdk
Copy link

openjdk bot commented May 17, 2024

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review May 18, 2024 00:39
@openjdk
Copy link

openjdk bot commented May 18, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 18, 2024
@mlbridge
Copy link

mlbridge bot commented May 18, 2024

Webrevs

@openjdk openjdk bot added the approval label May 20, 2024
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jun 3, 2024
@mrserb
Copy link
Member Author

mrserb commented Jun 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jun 5, 2024

Going to push as commit 07ea0f1.
Since your change was applied there have been 15 commits pushed to the master branch:

  • a51a9dd: 8315804: Open source several Swing JTabbedPane JTextArea JTextField tests
  • 0bacea4: 8310201: Reduce verbose locale output in -XshowSettings launcher option
  • 8a23308: 8320945: problemlist tests failing on latest Windows 11 update
  • f7e83e8: 8311666: Disabled tests in test/jdk/sun/java2d/marlin
  • b11a980: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address
  • 69f4ac1: 8240226: DeflateIn_InflateOut.java test incorrectly assumes size of compressed file
  • 4556aa9: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab
  • 7b377ac: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
  • 31a780d: 8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free
  • c35d30d: 8331263: Bump update version for OpenJDK: jdk-11.0.25
  • ... and 5 more: https://git.openjdk.org/jdk11u-dev/compare/1d6965fd4eba8c22589f1833e3a1639f05ada771...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 5, 2024
@openjdk openjdk bot closed this Jun 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 5, 2024
@openjdk
Copy link

openjdk bot commented Jun 5, 2024

@mrserb Pushed as commit 07ea0f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant