-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8240226: DeflateIn_InflateOut.java test incorrectly assumes size of compressed file #2719
Conversation
Hi @vieiro, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user vieiro" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
@vieiro This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
/covered |
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
/signed too |
|
/approval |
@vieiro usage: |
/approval JDK-8240226 request Backport DeflateIn_InflateOut: incorrectly assumes size of zipped file |
/integrate |
/sponsor |
Going to push as commit 69f4ac1.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr @vieiro Pushed as commit 69f4ac1. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Thank you, @TheRealMDoerr ! |
A backport of https://bugs.openjdk.org/browse/JDK-8240226
JDK-8240226 contains a small fix to
DeflateIn_InflateOut.java
that makes the test pass when--with-zlib=system
and the system zlib library is zlib-cloudflare.This fix is also required for the test to pass in Fedora 40 with the (system wide default) ZLib-ng library.
Tested with both DEBUG and RELEASE builds in Fedora 40.
Let me know if updating the copyright year is required.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2719/head:pull/2719
$ git checkout pull/2719
Update a local copy of the PR:
$ git checkout pull/2719
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2719/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2719
View PR using the GUI difftool:
$ git pr show -t 2719
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2719.diff
Webrev
Link to Webrev Comment