Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273153: Consolidate file_exists into os:file_exists #2721

Closed
wants to merge 1 commit into from

Conversation

elifaslan1
Copy link
Contributor

@elifaslan1 elifaslan1 commented May 23, 2024

This is not a clean backport. There was a merge conflict on os.cpp due to diverged os::split_path method for this reason os::file_exists method was manually added.
This backport is required to address a crash observed in Amazon production.

tier2 tests were run in addition to GHA


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8273153 needs maintainer approval

Issue

  • JDK-8273153: Consolidate file_exists into os:file_exists (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2721/head:pull/2721
$ git checkout pull/2721

Update a local copy of the PR:
$ git checkout pull/2721
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2721/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2721

View PR using the GUI difftool:
$ git pr show -t 2721

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2721.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2024

👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 23, 2024

@elifaslan1 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273153: Consolidate file_exists into os:file_exists

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 8a489e5: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 9732fbe428c3b6a5422cc94e7295ba5482d1a7a9 8273153: Consolidate file_exists into os:file_exists May 23, 2024
@openjdk
Copy link

openjdk bot commented May 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 23, 2024

⚠️ @elifaslan1 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 23, 2024
@mlbridge
Copy link

mlbridge bot commented May 23, 2024

Webrevs

@elifaslan1
Copy link
Contributor Author

elifaslan1 commented May 23, 2024

/approval JDK-8273153 request. This backport is not clean due to diverged os::split_path method.The purpose of this backport is to consolidate file_exists into os:file_exists. It aims to fix a crash observed on Amazon Production. Both Tier 2 and GHA tests passed.

@openjdk
Copy link

openjdk bot commented May 23, 2024

@elifaslan1
JDK-8273153: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 23, 2024
@elifaslan1
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

@elifaslan1
Your change (at version 7dbb958) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 28, 2024

Going to push as commit 47fd86c.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 8a489e5: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 28, 2024
@openjdk openjdk bot closed this May 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

@phohensee @elifaslan1 Pushed as commit 47fd86c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants