-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8273153: Consolidate file_exists into os:file_exists #2721
Conversation
👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into |
@elifaslan1 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval JDK-8273153 request. This backport is not clean due to diverged os::split_path method.The purpose of this backport is to consolidate file_exists into os:file_exists. It aims to fix a crash observed on Amazon Production. Both Tier 2 and GHA tests passed. |
@elifaslan1 |
/integrate |
@elifaslan1 |
/sponsor |
@phohensee @elifaslan1 Pushed as commit 47fd86c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is not a clean backport. There was a merge conflict on os.cpp due to diverged os::split_path method for this reason os::file_exists method was manually added.
This backport is required to address a crash observed in Amazon production.
tier2 tests were run in addition to GHA
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2721/head:pull/2721
$ git checkout pull/2721
Update a local copy of the PR:
$ git checkout pull/2721
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2721/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2721
View PR using the GUI difftool:
$ git pr show -t 2721
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2721.diff
Webrev
Link to Webrev Comment