Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls #2732

Closed
wants to merge 1 commit into from
Closed

8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls #2732

wants to merge 1 commit into from

Conversation

fitzsim
Copy link
Contributor

@fitzsim fitzsim commented May 31, 2024 •
edited by openjdk bot
Loading

8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls

Reviewed-by: kbarrett, djelinski
Backport-of: d7298245d6759f62e253b5cf0df975db17fdbf82

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8286781 needs maintainer approval

Issue

  • JDK-8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2732/head:pull/2732
$ git checkout pull/2732

Update a local copy of the PR:
$ git checkout pull/2732
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2732/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2732

View PR using the GUI difftool:
$ git pr show -t 2732

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2732.diff

Webrev

Link to Webrev Comment

@fitzsim @djelinski
8286781: Replace the deprecated/obsolete gethostbyname and inet_addr …
8185b2c 
…calls

Co-authored-by: Daniel Jeliński <djelinski@openjdk.org>
Reviewed-by: kbarrett, djelinski
Backport-of: d7298245d6759f62e253b5cf0df975db17fdbf82
@bridgekeeper
Copy link

bridgekeeper bot commented May 31, 2024

👋 Welcome back fitzsim! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 31, 2024 •
edited
Loading

@fitzsim This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • e72f491: 8333724: Problem list security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1
  • d659ff6: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
  • 69b6e6d: 8329004: Update Libpng to 1.6.43
  • bc8aeb6: 8328999: Update GIFlib to 5.2.2
  • f010fe0: 8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04
  • ee370ed: 8242999: HTTP/2 client may not handle CONTINUATION frames correctly
  • 48cf5a3: Merge
  • d3bd5ae: 8331750: [11u] JDK-8259530 is not backported correctly to 11u
  • 15c9397: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message
  • f45455e: 8322330: JavadocHelperTest.java OOMEs with Parallel GC and ZGC
  • ... and 10 more: https://git.openjdk.org/jdk11u-dev/compare/c35d30d6fecabcb10cd2011fca39ddee219337b0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport d7298245d6759f62e253b5cf0df975db17fdbf82 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls May 31, 2024
@openjdk
Copy link

openjdk bot commented May 31, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 31, 2024
@fitzsim
Copy link
Contributor Author

fitzsim commented May 31, 2024

The GHA sanity checks failed at first on the macOS builders, but the error was not clear -- it just looked like the jobs terminated -- so I restarted those subtasks and they passed.

@mlbridge
Copy link

mlbridge bot commented May 31, 2024

Webrevs

gnu-andrew
gnu-andrew approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When backporting, it would be good if you could detail any changes you had to make to get the patch to apply and build on the new target.

From comparing the 11u & 17u versions, the changes I see are:

  1. Context difference in make/autoconf/libraries.m4
  2. NULL vs nullptr in src/hotspot/share/utilities/ostream.cpp
  3. Absence of JDK-8265101 so os::get_host_by_name has to be removed from AIX, BSD, Linux and Solaris os_<os>.inline.hpp files rather than just os_posix.cpp

Assuming these changes tally with your experience, this seems fine to me.

@openjdk
Copy link

openjdk bot commented Jun 6, 2024

⚠️ @fitzsim This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@fitzsim
Copy link
Contributor Author

fitzsim commented Jun 6, 2024

When backporting, it would be good if you could detail any changes you had to make to get the patch to apply and build on the new target.

Noted, will do from now on.

From comparing the 11u & 17u versions, the changes I see are:

1. Context difference in `make/autoconf/libraries.m4`

2. `NULL` vs `nullptr` in `src/hotspot/share/utilities/ostream.cpp`

3. Absence of [JDK-8265101](https://bugs.openjdk.org/browse/JDK-8265101) so `os::get_host_by_name` has to be removed from AIX, BSD, Linux and Solaris `os_<os>.inline.hpp` files rather than just `os_posix.cpp`

Assuming these changes tally with your experience, this seems fine to me.

Yes, that sounded right, and I just re-verified that the differences you mention are the only ones, by comparing this proposed patch to 11 with openjdk/jdk17u-dev@4071b8c.

@fitzsim
Copy link
Contributor Author

fitzsim commented Jun 6, 2024

Thank you for reviewing, @gnu-andrew.

@fitzsim
Copy link
Contributor Author

fitzsim commented Jun 6, 2024

/approval request This backport is ready to be approved.

@openjdk
Copy link

openjdk bot commented Jun 6, 2024

@fitzsim
8286781: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 6, 2024
@fitzsim
Copy link
Contributor Author

fitzsim commented Jun 7, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 7, 2024
@openjdk
Copy link

openjdk bot commented Jun 7, 2024

@fitzsim
Your change (at version 8185b2c) is now ready to be sponsored by a Committer.

@gnu-andrew
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 8, 2024

Going to push as commit e4fb228.
Since your change was applied there have been 20 commits pushed to the master branch:

  • e72f491: 8333724: Problem list security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1
  • d659ff6: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
  • 69b6e6d: 8329004: Update Libpng to 1.6.43
  • bc8aeb6: 8328999: Update GIFlib to 5.2.2
  • f010fe0: 8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04
  • ee370ed: 8242999: HTTP/2 client may not handle CONTINUATION frames correctly
  • 48cf5a3: Merge
  • d3bd5ae: 8331750: [11u] JDK-8259530 is not backported correctly to 11u
  • 15c9397: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message
  • f45455e: 8322330: JavadocHelperTest.java OOMEs with Parallel GC and ZGC
  • ... and 10 more: https://git.openjdk.org/jdk11u-dev/compare/c35d30d6fecabcb10cd2011fca39ddee219337b0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 8, 2024
@openjdk openjdk bot closed this Jun 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 8, 2024
@openjdk
Copy link

openjdk bot commented Jun 8, 2024

@gnu-andrew @fitzsim Pushed as commit e4fb228.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnu-andrew gnu-andrew gnu-andrew approved these changes

Assignees
No one assigned
Labels
backport integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fitzsim @gnu-andrew