Skip to content

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 5, 2024

Backport of JDK-8305825. Version from 17u applies cleanly except ProblemList update which is integrated manually and recognized as clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8305825 needs maintainer approval

Issue

  • JDK-8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2745/head:pull/2745
$ git checkout pull/2745

Update a local copy of the PR:
$ git checkout pull/2745
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2745/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2745

View PR using the GUI difftool:
$ git pr show -t 2745

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2745.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 5, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 5, 2024

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • ee370ed: 8242999: HTTP/2 client may not handle CONTINUATION frames correctly
  • 48cf5a3: Merge
  • d3bd5ae: 8331750: [11u] JDK-8259530 is not backported correctly to 11u
  • 15c9397: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message
  • f45455e: 8322330: JavadocHelperTest.java OOMEs with Parallel GC and ZGC
  • 07ea0f1: 8331746: Create a test to verify that the cmm id is not ignored

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport ab84520d73a63601d75e45895663d8216ca20962 8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04 Jun 5, 2024
@openjdk
Copy link

openjdk bot commented Jun 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 5, 2024
@openjdk
Copy link

openjdk bot commented Jun 5, 2024

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 5, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 5, 2024

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/approval request Should get backported for parity with 11.0.25-oracle. Version from JDK17u applies cleanly and tier1-4 have passed.

@openjdk
Copy link

openjdk bot commented Jun 6, 2024

@TheRealMDoerr
8305825: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jun 6, 2024
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 6, 2024

Going to push as commit f010fe0.
Since your change was applied there have been 6 commits pushed to the master branch:

  • ee370ed: 8242999: HTTP/2 client may not handle CONTINUATION frames correctly
  • 48cf5a3: Merge
  • d3bd5ae: 8331750: [11u] JDK-8259530 is not backported correctly to 11u
  • 15c9397: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message
  • f45455e: 8322330: JavadocHelperTest.java OOMEs with Parallel GC and ZGC
  • 07ea0f1: 8331746: Create a test to verify that the cmm id is not ignored

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 6, 2024
@openjdk openjdk bot closed this Jun 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 6, 2024
@openjdk
Copy link

openjdk bot commented Jun 6, 2024

@TheRealMDoerr Pushed as commit f010fe0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8305825_X11 branch June 6, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant