8268906: gc/g1/mixedgc/TestOldGenCollectionUsage.java assumes that GCs take 1ms minimum

[sendaoYan]

Hi all,

This pull request contains a backport of commit a0f32cb1 from the openjdk/jdk repository.

The commit being backported was authored by Thomas Schatzl on 30 Jun 2021 and was reviewed by Kim Barrett, Albert Mingkun Yang and Leo Korinth.

The related failure was caught by dragonwell's CI. So we want to fix the intermittent failure. Only change the testcase, the risk is low.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8268906 needs maintainer approval

Issue

• JDK-8268906: gc/g1/mixedgc/TestOldGenCollectionUsage.java assumes that GCs take 1ms minimum (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2747/head:pull/2747
$ git checkout pull/2747

Update a local copy of the PR:
$ git checkout pull/2747
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2747/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2747

View PR using the GUI difftool:
$ git pr show -t 2747

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2747.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8268906: gc/g1/mixedgc/TestOldGenCollectionUsage.java assumes that GCs take 1ms minimum

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

• 3b4f583: 8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out
• 7198ea1: 8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out
• 2a5ba0a: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
• 7e1e239: 8315898: Open source swing JMenu tests
• 4a28ac0: 8306060: Open source few AWT Insets related tests
• b0ad167: 8306850: Open source AWT Modal related tests
• e726fe7: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
• 9f58121: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet
• e541cbd: 8320079: The ArabicBox.java test has no control buttons
• 0e74e1b: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
• ... and 34 more: https://git.openjdk.org/jdk11u-dev/compare/d659ff6a39440ae43e42695966fc3f08cde085f8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[sendaoYan]

/approval request Clean backport to fix the intermittent failure. Only change the testcase, the risk is low.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@sendaoYan
8268906: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (f46f525f)

[sendaoYan]

Thanks for the approved.
/integrate

[openjdk]

@sendaoYan
Your change (at version f46f525) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit f8e87df.
Since your change was applied there have been 44 commits pushed to the master branch:

• 3b4f583: 8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out
• 7198ea1: 8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out
• 2a5ba0a: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
• 7e1e239: 8315898: Open source swing JMenu tests
• 4a28ac0: 8306060: Open source few AWT Insets related tests
• b0ad167: 8306850: Open source AWT Modal related tests
• e726fe7: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
• 9f58121: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet
• e541cbd: 8320079: The ArabicBox.java test has no control buttons
• 0e74e1b: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
• ... and 34 more: https://git.openjdk.org/jdk11u-dev/compare/d659ff6a39440ae43e42695966fc3f08cde085f8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @sendaoYan Pushed as commit f8e87df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[sendaoYan]

/sponsor

Thanks for the sponsor.