Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272472: StackGuardPages test doesn't build with glibc 2.34 #275

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Aug 23, 2021

Clean backport to get newer glibc working for this test.

Additional testing:

  • Test still works on older glibc

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272472: StackGuardPages test doesn't build with glibc 2.34

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/275/head:pull/275
$ git checkout pull/275

Update a local copy of the PR:
$ git checkout pull/275
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 275

View PR using the GUI difftool:
$ git pr show -t 275

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/275.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 23, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f77a1a156f3da9068d012d9227c7ee0fee58f571 8272472: StackGuardPages test doesn't build with glibc 2.34 Aug 23, 2021
@openjdk
Copy link

openjdk bot commented Aug 23, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 23, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8272472: StackGuardPages test doesn't build with glibc 2.34

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • ba097ca: 8251549: Update docs on building for Git
  • 3a88ae7: Merge
  • 3a32efc: Merge
  • fdbaa23: Merge
  • f4772b5: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used
  • 90d5293: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 23, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 23, 2021

Webrevs

@shipilev
Copy link
Member Author

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 24, 2021

Going to push as commit 417b388.
Since your change was applied there have been 14 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 24, 2021
@openjdk
Copy link

openjdk bot commented Aug 24, 2021

@shipilev Pushed as commit 417b388.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8272472 branch August 26, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant