8333837: [11u] HexPrinterTest.java javac compile fails illegal start of expression

[sendaoYan]

Hi all,
The testcase test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java fails because of Java 11 doesn't support var v = switch(String) { case String -> ... } syntax. This testcase was backported by JDK-8329248 from jdk15. This PR fix the syntax error to make the testcase work normally.
Only change the testcase, the change has been verified, no risk.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8333837 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8333837: [11u] HexPrinterTest.java javac compile fails illegal start of expression (Bug - P3 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2750/head:pull/2750
$ git checkout pull/2750

Update a local copy of the PR:
$ git checkout pull/2750
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2750/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2750

View PR using the GUI difftool:
$ git pr show -t 2750

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2750.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8333837: [11u] HexPrinterTest.java javac compile fails illegal start of expression

Reviewed-by: mdoerr, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 316cd2f: 7124313: [macosx] Swing Popups should overlap taskbar
• 54bf522: 8307091: A few client tests intermittently throw ConcurrentModificationException
• 2ded016: 8329995: Restricted access to /proc can cause JFR initialization to crash
• bf56996: 8316104: Open source several Swing SplitPane and RadioButton related tests
• 2f7954c: 8294148: Support JSplitPane for instructions and test UI
• f36ba5a: 8328218: Delete test java/awt/Window/FindOwner/FindOwner.html
• b5cbf8d: 8328561: test java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used
• aa0bba2: 8328234: Remove unused nativeUtils files
• e4fb228: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[sendaoYan]

/approval request Fix a testcase bug, the change has been verified, no risk.

[openjdk]

@sendaoYan
8333837: The approval request has been created successfully.

[mlbridge]

Webrevs

• 01: Full - Incremental (873c017c)
• 00: Full (a95f8fcd)

[TheRealMDoerr]

Please fix the link in the description. The related issue is JDK-8329248. I think it's better not to update the Copyright because you are only repairing a backport. We usually avoid touching the Copyright headers for backports unless the original change updates it. Otherwise, LGTM. Thanks for fixing it!

[sendaoYan]

Please fix the link in the description. The related issue is JDK-8329248. I think it's better not to update the Copyright because you are only repairing a backport. We usually avoid touching the Copyright headers for backports unless the original change updates it. Otherwise, LGTM. Thanks for fixing it!

Thanks for the correction, the description has been fixed. And the copyright year change has been revert.

[TheRealMDoerr]

Thanks for fixing it!

[sendaoYan]

Thanks for the review.
/approval request Fix testcase bug, the change has been verified, no risk.

[openjdk]

@sendaoYan
8333837: The approval request has been updated successfully.

[sendaoYan]

The GHA test runner report a intermittent failure, seems to be recorded by JDK-8229253. I think it's unrelated to this PR.

test FJExceptionTableLeak.exceptionTableCleanup(): failure
java.lang.AssertionError: failed to satisfy condition
	at FJExceptionTableLeak.gcAwait(FJExceptionTableLeak.java:202)
	at FJExceptionTableLeak.exceptionTableCleanup(FJExceptionTableLeak.java:137)

[TheRealMDoerr]

The latest GHA run didn't show any failures.

[sendaoYan]

The latest GHA run didn't show any failures.

Yes, I rerun the failed job manual.

[sendaoYan]

Thanks for the review and approved.
/integrate

[openjdk]

@sendaoYan
Your change (at version 873c017) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit c9cc14b.
Since your change was applied there have been 10 commits pushed to the master branch:

• f343625: 8333839: [11u] LingeredAppTest.java fails Can't find source file: LingeredApp.java
• 316cd2f: 7124313: [macosx] Swing Popups should overlap taskbar
• 54bf522: 8307091: A few client tests intermittently throw ConcurrentModificationException
• 2ded016: 8329995: Restricted access to /proc can cause JFR initialization to crash
• bf56996: 8316104: Open source several Swing SplitPane and RadioButton related tests
• 2f7954c: 8294148: Support JSplitPane for instructions and test UI
• f36ba5a: 8328218: Delete test java/awt/Window/FindOwner/FindOwner.html
• b5cbf8d: 8328561: test java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used
• aa0bba2: 8328234: Remove unused nativeUtils files
• e4fb228: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @sendaoYan Pushed as commit c9cc14b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[sendaoYan]

Thanks all for the review and sponsor.