Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed." #2754

Closed
wants to merge 3 commits into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Jun 11, 2024

I backport this for parity with 11.0.25-oracle.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8280392 needs maintainer approval

Issue

  • JDK-8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed." (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2754/head:pull/2754
$ git checkout pull/2754

Update a local copy of the PR:
$ git checkout pull/2754
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2754/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2754

View PR using the GUI difftool:
$ git pr show -t 2754

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2754.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 11, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 11, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 3f2e849c54c2a9c55e3b5c9f5a6d3478b83144e3 8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed." Jun 11, 2024
@openjdk
Copy link

openjdk bot commented Jun 11, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 11, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 11, 2024

Webrevs

@luchenlin luchenlin closed this Jun 11, 2024
@Eitanull Eitanull deleted the backport_8280392 branch June 11, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
2 participants