Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316240: Open source several add/remove MenuBar manual tests #2757

Closed
wants to merge 3 commits into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Jun 11, 2024

This PR contains a backport of
openjdk/jdk@3809d69
Patch is not clean, these classes contains the Text Blocks, but in jdk11 the Text Blocks is not supported.
Other than these the rest of the code is clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316240 needs maintainer approval

Issue

  • JDK-8316240: Open source several add/remove MenuBar manual tests (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2757/head:pull/2757
$ git checkout pull/2757

Update a local copy of the PR:
$ git checkout pull/2757
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2757/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2757

View PR using the GUI difftool:
$ git pr show -t 2757

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2757.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 11, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 11, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 3809d69ac4b3d186ccdc336949b658e4671347c8 8316240: Open source several add/remove MenuBar manual tests Jun 11, 2024
@openjdk
Copy link

openjdk bot commented Jun 11, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 11, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 11, 2024

Webrevs

@Eitanull Eitanull deleted the backport_8316240 branch June 11, 2024 06:21
@luchenlin luchenlin closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants