Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed." #2758

Closed
wants to merge 1 commit into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Jun 11, 2024

I backport this for parity with 11.0.25-oracle.
java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java 8280392 windows-x64
not in problem.txt make it clean


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8280392 needs maintainer approval

Issue

  • JDK-8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed." (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2758/head:pull/2758
$ git checkout pull/2758

Update a local copy of the PR:
$ git checkout pull/2758
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2758/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2758

View PR using the GUI difftool:
$ git pr show -t 2758

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2758.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 11, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 11, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed."

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 5dddf69: 8279164: Disable TLS_ECDH_* cipher suites
  • be6c621: 8305072: Win32ShellFolder2.compareTo is inconsistent
  • 9a2a828: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests
  • 46b15b9: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests
  • c9cc14b: 8333837: [11u] HexPrinterTest.java javac compile fails illegal start of expression
  • f343625: 8333839: [11u] LingeredAppTest.java fails Can't find source file: LingeredApp.java
  • 316cd2f: 7124313: [macosx] Swing Popups should overlap taskbar
  • 54bf522: 8307091: A few client tests intermittently throw ConcurrentModificationException
  • 2ded016: 8329995: Restricted access to /proc can cause JFR initialization to crash
  • bf56996: 8316104: Open source several Swing SplitPane and RadioButton related tests
  • ... and 22 more: https://git.openjdk.org/jdk11u-dev/compare/4556aa9d5e42a4afbc6ea749b589d4442e311d24...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 3f2e849c54c2a9c55e3b5c9f5a6d3478b83144e3 8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed." Jun 11, 2024
@openjdk
Copy link

openjdk bot commented Jun 11, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 11, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 11, 2024

Webrevs

@luchenlin
Copy link
Contributor Author

/clean

@openjdk openjdk bot added the clean label Jun 11, 2024
@openjdk
Copy link

openjdk bot commented Jun 11, 2024

@luchenlin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jun 11, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 12, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 14, 2024

Going to push as commit 3901633.
Since your change was applied there have been 33 commits pushed to the master branch:

  • dff2d60: 8323670: A few client tests intermittently throw ConcurrentModificationException
  • 5dddf69: 8279164: Disable TLS_ECDH_* cipher suites
  • be6c621: 8305072: Win32ShellFolder2.compareTo is inconsistent
  • 9a2a828: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests
  • 46b15b9: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests
  • c9cc14b: 8333837: [11u] HexPrinterTest.java javac compile fails illegal start of expression
  • f343625: 8333839: [11u] LingeredAppTest.java fails Can't find source file: LingeredApp.java
  • 316cd2f: 7124313: [macosx] Swing Popups should overlap taskbar
  • 54bf522: 8307091: A few client tests intermittently throw ConcurrentModificationException
  • 2ded016: 8329995: Restricted access to /proc can cause JFR initialization to crash
  • ... and 23 more: https://git.openjdk.org/jdk11u-dev/compare/4556aa9d5e42a4afbc6ea749b589d4442e311d24...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 14, 2024
@openjdk openjdk bot closed this Jun 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 14, 2024
@openjdk
Copy link

openjdk bot commented Jun 14, 2024

@luchenlin Pushed as commit 3901633.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant