8305072: Win32ShellFolder2.compareTo is inconsistent

[TheRealMDoerr]

Clean backport of JDK-8305072.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8305072 needs maintainer approval

Issue

• JDK-8305072: Win32ShellFolder2.compareTo is inconsistent (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2764/head:pull/2764
$ git checkout pull/2764

Update a local copy of the PR:
$ git checkout pull/2764
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2764/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2764

View PR using the GUI difftool:
$ git pr show -t 2764

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2764.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8305072: Win32ShellFolder2.compareTo is inconsistent

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• c9cc14b: 8333837: [11u] HexPrinterTest.java javac compile fails illegal start of expression
• f343625: 8333839: [11u] LingeredAppTest.java fails Can't find source file: LingeredApp.java
• 316cd2f: 7124313: [macosx] Swing Popups should overlap taskbar
• 54bf522: 8307091: A few client tests intermittently throw ConcurrentModificationException
• 2ded016: 8329995: Restricted access to /proc can cause JFR initialization to crash

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (fa6033aa)

[TheRealMDoerr]

/approval request Should get backported for parity with 11.0.25-oracle. Applies cleanly and tier 1-4 have passed.

[openjdk]

@TheRealMDoerr
8305072: The approval request has been created successfully.

[TheRealMDoerr]

/integrate

[openjdk]

Going to push as commit be6c621.
Since your change was applied there have been 7 commits pushed to the master branch:

• 9a2a828: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests
• 46b15b9: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests
• c9cc14b: 8333837: [11u] HexPrinterTest.java javac compile fails illegal start of expression
• f343625: 8333839: [11u] LingeredAppTest.java fails Can't find source file: LingeredApp.java
• 316cd2f: 7124313: [macosx] Swing Popups should overlap taskbar
• 54bf522: 8307091: A few client tests intermittently throw ConcurrentModificationException
• 2ded016: 8329995: Restricted access to /proc can cause JFR initialization to crash

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit be6c621.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.